Page MenuHomeFreeBSD
Differential D48603

net80211: change ieee80211_ratectl_rate() to not return a rix
Needs ReviewPublic
Actions

Authored by adrian on Thu, Jan 23, 2:35 AM.
Tags
Referenced Files
F109267243: D48603.diff
Sun, Feb 2, 7:55 PM
F109239929: D48603.id150160.diff
Sun, Feb 2, 11:57 AM
F109239463: D48603.id149895.diff
Sun, Feb 2, 11:47 AM
F109233024: D48603.id150145.diff
Sun, Feb 2, 9:45 AM
F109217918: D48603.id149732.diff
Sun, Feb 2, 4:58 AM
Unknown Object (File)
Wed, Jan 29, 8:41 AM
Unknown Object (File)
Tue, Jan 28, 4:22 PM
Unknown Object (File)
Tue, Jan 28, 3:49 PM
View All 10 Files
Subscribers
bz
emaste
glebius
imp
melifaro
thj
linuxkpi

Details

Reviewers
bz
Group Reviewers
wireless
Summary

There are only a few places where the returned rix is used:

  • linuxkpi - logging
  • bwi/bwn - used for finding a fallback rate to choose, which honestly should be returned by the ratectl API
  • iwm - building the rateset to program into firmware

Everyone else uses the dot11rate value in ni->ni_txnode.

This is a precursor for VHT and later rate support; where currently
there aren't rate tables in ieee80211_phy.c for VHT and later
rates.

Although it's likely doable to add tables for VHT, 11ax and MU-OFDMA
(HE) rates are sufficiently larger/different to just not fit in the
current scheme without more refactoring.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62107
Build 58991: arc lint + arc unit

Event Timeline

adrian created this revision.Thu, Jan 23, 2:35 AM
Herald added subscribers: linuxkpi, glebius, melifaro and 2 others. · View Herald TranscriptThu, Jan 23, 2:35 AM
adrian requested review of this revision.Thu, Jan 23, 2:35 AM
Harbormaster completed remote builds in B61894: Diff 149732.Thu, Jan 23, 2:35 AM
adrian added a parent revision: D48602: sys: convert ni->ni_txrate references use to the new net80211 API.Thu, Jan 23, 2:35 AM
adrian added a child revision: D48604: net80211: convert ni_txrate to a struct, with extra rate information.
adrian added a reviewer: wireless.Thu, Jan 23, 3:02 AM
adrian added a project: wireless.
adrian updated this revision to Diff 149843.Fri, Jan 24, 1:50 AM

rebsae

Harbormaster completed remote builds in B61954: Diff 149843.Fri, Jan 24, 1:50 AM
adrian updated this revision to Diff 149895.Fri, Jan 24, 3:31 PM

rebase

Harbormaster completed remote builds in B61981: Diff 149895.Fri, Jan 24, 3:31 PM
thj added a subscriber: thj.Fri, Jan 24, 4:22 PM
thj added inline comments.
sys/compat/linuxkpi/common/src/linux_80211.c
5970

This cast isn't needed

adrian added inline comments.Sat, Jan 25, 8:33 PM
sys/compat/linuxkpi/common/src/linux_80211.c
5970

I'm so used to using/building in envs where you get a warning if you don't handle the return value. :-) Lemme go make sure that doesn't happen here on all of our branches and then I'll go remove em all.

bz requested changes to this revision.Sun, Jan 26, 10:31 PM
bz added a subscriber: bz.
bz added inline comments.
sys/compat/linuxkpi/common/src/linux_80211.c
5970

remove it!

sys/dev/iwm/if_iwm.c
4579

Please declare within proper scope or pass the result from the function to the next w/o variable. A dot11rate is an uint8_t anyway

sys/net80211/ieee80211_ratectl.h
135

Cast not needed.

This revision now requires changes to proceed.Sun, Jan 26, 10:31 PM
adrian updated this revision to Diff 149999.Mon, Jan 27, 12:15 AM

rebase, address changes

Harbormaster completed remote builds in B62047: Diff 149999.Mon, Jan 27, 12:15 AM
adrian updated this revision to Diff 150141.Thu, Jan 30, 2:27 AM

address comments

Harbormaster completed remote builds in B62107: Diff 150141.Thu, Jan 30, 2:27 AM
adrian marked 4 inline comments as done.Thu, Jan 30, 2:27 AM

updated, please re-review!

adrian updated this revision to Diff 150145.Thu, Jan 30, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62110: Diff 150145.Thu, Jan 30, 5:15 AM
adrian updated this revision to Diff 150160.Thu, Jan 30, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62125: Diff 150160.Thu, Jan 30, 5:15 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
7 lines
dev/
bwi/
13 lines
bwn/
12 lines
iwm/
28 lines
net80211/
4 lines

Diff 150141

View Options

sys/compat/linuxkpi/common/src/linux_80211.c

Loading...
View Options

sys/dev/bwi/if_bwi.c

Loading...
View Options

sys/dev/bwn/if_bwn.c

Loading...
View Options

sys/dev/iwm/if_iwm.c

Loading...
View Options

sys/net80211/ieee80211_ratectl.h

Loading...