Page MenuHomeFreeBSD
Differential D48488

bus.h: remove unused devop_t typedef
AcceptedPublic
Actions

Authored by mhorne on Thu, Jan 16, 5:22 PM.
Tags
None
Referenced Files
F108048585: D48488.diff
Mon, Jan 20, 9:48 PM
Unknown Object (File)
Sun, Jan 19, 9:54 AM
Unknown Object (File)
Sun, Jan 19, 3:19 AM
Unknown Object (File)
Sun, Jan 19, 1:05 AM
Unknown Object (File)
Sat, Jan 18, 10:53 PM
Unknown Object (File)
Sat, Jan 18, 3:38 PM
Unknown Object (File)
Fri, Jan 17, 8:41 PM
Unknown Object (File)
Fri, Jan 17, 4:51 PM
View All 9 Files
Subscribers
None

Details

Reviewers
jhb
imp
Summary

Passes tinderbox.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61770
Build 58654: arc lint + arc unit

Event Timeline

mhorne requested review of this revision.Thu, Jan 16, 5:22 PM
mhorne created this revision.
mhorne added a parent revision: D48487: bus.h: remove deprecated struct driver.
mhorne added a child revision: D48489: EARLY_DRIVER_MODULE: use designated initializers.
Harbormaster completed remote builds in B61770: Diff 149357.Thu, Jan 16, 5:22 PM
imp accepted this revision.Thu, Jan 16, 5:30 PM

This has been unused since

commit f7b776917236d24a4ac7aaa19b3595abdd8411f9
Author: Doug Rabson <dfr@FreeBSD.org>
Date:   Sat Apr 8 14:17:18 2000 +0000

    * Factor out the object system from new-bus so that it can be used by
      non-device code.
    * Re-implement the method dispatch to improve efficiency. The new system
      takes about 40ns for a method dispatch on a 300Mhz PII which is only
      10ns slower than a direct function call on the same hardware.

    This changes the new-bus ABI slightly so make sure you re-compile any
    driver modules which you use.

I don't think we're being too hasty removing it. It used to be used a pointer to the compiled ops (method) table.

This revision is now accepted and ready to land.Thu, Jan 16, 5:30 PM
mhorne added a comment.Thu, Jan 16, 5:32 PM
In D48488#1106326, @imp wrote:

This has been unused since

commit f7b776917236d24a4ac7aaa19b3595abdd8411f9
Author: Doug Rabson <dfr@FreeBSD.org>
Date:   Sat Apr 8 14:17:18 2000 +0000

    * Factor out the object system from new-bus so that it can be used by
      non-device code.
    * Re-implement the method dispatch to improve efficiency. The new system
      takes about 40ns for a method dispatch on a 300Mhz PII which is only
      10ns slower than a direct function call on the same hardware.

    This changes the new-bus ABI slightly so make sure you re-compile any
    driver modules which you use.

I don't think we're being too hasty removing it. It used to be used a pointer to the compiled ops (method) table.

Thanks, I will include this info in the commit message.

jhb accepted this revision.Sat, Jan 18, 2:31 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
2 lines

Diff 149357

View Options

sys/sys/bus.h

Loading...