Page MenuHomeFreeBSD

machine/param.h: drop __HAVE_ACPI define
AcceptedPublic

Authored by mhorne on Thu, Jan 16, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 11:33 AM
Unknown Object (File)
Sat, Jan 18, 6:24 AM
Unknown Object (File)
Sat, Jan 18, 6:14 AM
Unknown Object (File)
Fri, Jan 17, 12:29 AM
Unknown Object (File)
Fri, Jan 17, 12:23 AM
Subscribers
None

Details

Reviewers
jhb
imp
Summary

It is no longer used anywhere, and not defined for arm64 which also
supports ACPI.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61768
Build 58652: arc lint + arc unit

Event Timeline

mhorne created this revision.
This revision is now accepted and ready to land.Thu, Jan 16, 5:35 PM

As I note in the other review, this has been unused since:

commit 62508c531e0f19a9154670a3cd820164c486131f
Author: John Baldwin <jhb@FreeBSD.org>
Date:   Tue Aug 17 15:44:52 2010 +0000

    Add a new method to the PCI bridge interface, PCIB_POWER_FOR_SLEEP().  This
    method is used by the PCI bus driver to query the power management system
    to determine the proper device state to be used for a device during suspend
    and resume.  For the ACPI PCI bridge drivers this calls
    acpi_device_pwr_for_sleep().  This removes ACPI-specific knowledge from
    the PCI and PCI-PCI bridge drivers.
    
    Reviewed by:    jkim

Notes:
    svn path=/head/; revision=211430

NetBSD does this more extensively and we picked up the habit from them, but have been somewhat bad about keeping up with it, even by 2010