nvmecontrol: Only do name resolution once for Fabrics connections
AcceptedPublic
Actions

Authored by jhb on Tue, Jan 14, 5:33 PM.

Details

Reviewers

Summary

Reuse the addrinfo structure from the admin queue to establish
connections to I/O queues for the TCP transport.

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61950
Build 58834: arc lint + arc unit

jhb requested review of this revision.Tue, Jan 14, 5:33 PM

Rebase

This revision is now accepted and ready to land.Tue, Jan 14, 10:08 PM

dab requested changes to this revision.Sat, Jan 18, 1:46 AM

dab added inline comments.

sbin/nvmecontrol/fabrics.c
504	Isn't a `freeaddrinfo(list);` needed here before the `return`? Perhaps a new error-out goto label to consolidate the error cases where just that is needed.

This revision now requires changes to proceed.Sat, Jan 18, 1:46 AM

sbin/nvmecontrol/fabrics.c
504	oh my! I missed this, but I think you're right.

sbin/nvmecontrol/fabrics.c
504	Isn't a `freeaddrinfo(list);` needed here before the `return`? Perhaps a new error-out goto label to consolidate the error cases where just that is needed. Hmmm, if I clear the io[] array earlier, then the existing `out` label can work for most of these.