Differential D48420

clock: Simplify subr_ticks and rename
ClosedPublic
Actions

Authored by markj on Fri, Jan 10, 5:25 PM.

Tags

None

Referenced Files

	F107165177: D48420.id149078.diff
	Sat, Jan 11, 3:05 AM

	F107156748: D48420.diff
	Sat, Jan 11, 12:00 AM

	F107156340: D48420.diff
	Fri, Jan 10, 11:52 PM

Subscribers

Details

Reviewers

jrtc27
olce
kib
imp
emaste

Commits

rGb2b974f7ef4c: clock: Simplify subr_ticks and rename

Summary

We can use builtin constants for the size of int and long.
The file should have a .S prefix since we want to run it through the preprocessor, though apparently this happens anyway with .s...

Reported by: jrtc27
Fixes: 6b82130e6c9a ("clock: Add a long ticks variable, ticksl")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Fri, Jan 10, 5:25 PM

Herald added a subscriber: emaste. · View Herald TranscriptFri, Jan 10, 5:25 PM

markj requested review of this revision.Fri, Jan 10, 5:25 PM

Harbormaster completed remote builds in B61650: Diff 149077.Fri, Jan 10, 5:25 PM

jrtc27 added inline comments.Fri, Jan 10, 5:32 PM

Makefile.inc1
1773 ↗	(On Diff #149077)	If the window of time is small enough do we need to bother?...
sys/kern/subr_ticks.S
22	You missed the change to this line, otherwise it's wrong for 32-bit little endian.
25	As mentioned in my later follow-up, this should be .bss

jrtc27 added inline comments.Fri, Jan 10, 5:34 PM

sys/kern/subr_ticks.S
22	Uh, 32-bit big endian, even

Remove the .depend cleanup hack, fix the TICKS_OFFSET definition, move to .bss.

Harbormaster completed remote builds in B61651: Diff 149078.Fri, Jan 10, 5:37 PM

(but please mention BSS in the commit message)

This revision is now accepted and ready to land.Fri, Jan 10, 5:41 PM

emaste accepted this revision.Fri, Jan 10, 5:45 PM

kib accepted this revision.Fri, Jan 10, 6:17 PM

Closed by commit rGb2b974f7ef4c: clock: Simplify subr_ticks and rename (authored by markj). · Explain WhySat, Jan 11, 12:01 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGb2b974f7ef4c: clock: Simplify subr_ticks and rename.

Revision Contents
Changeset List

Path

Size

sys/

conf/

2 lines

kern/

	subr_ticks.S
	subr_ticks.s

22 lines

Diff 149107

sys/conf/files

Loading...

sys/kern/subr_ticks.S

Loading...

sys/kern/subr_ticks.s

Loading...