tee: add some basic tests
ClosedPublic
Actions

Authored by kevans on Dec 24 2024, 6:10 PM.

Details

Reviewers

des
emaste

Group Reviewers

tests

Commits

rG85ff0b08ee69: tee: add some basic tests

Summary

The cases are ordered in such a way that we naturally progress through
the functionality, with the earliest failures perhaps shedding light on
any later failures.

sysutils/porch is used for one test if it's available, just to cleanly
check that SIGINT is being ignored properly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Dec 24 2024, 6:10 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 24 2024, 6:10 PM

kevans requested review of this revision.Dec 24 2024, 6:10 PM

kevans added a child revision: D48196: tee: minor cleanup.

Harbormaster completed remote builds in B61320: Diff 148374.Dec 24 2024, 6:11 PM

des accepted this revision.Dec 26 2024, 1:33 PM

This revision is now accepted and ready to land.Dec 26 2024, 1:33 PM

Looks fine to me other than a comment that seems to be cut off that can be fixed on commit

usr.bin/tee/tests/tee_test.sh
48	to avoid what?

ngie added a subscriber: ngie.Dec 26 2024, 10:03 PM

ngie added inline comments.

usr.bin/tee/Makefile
2	superfluous line.
usr.bin/tee/tests/tee_test.sh
55

kevans marked 3 inline comments as done.Dec 27 2024, 4:08 AM

kevans added inline comments.

usr.bin/tee/tests/tee_test.sh
48	I really don't know where that train of thought was going, but we'll just finish that with: "to avoid adding a lot of complexity in trying to manage an input + signal delivery dance purely in shell."