tee: try opening as a UNIX socket if open(2) fails
AcceptedPublic
Actions

Authored by kevans on Tue, Dec 24, 10:30 PM.

Details

Reviewers

des
emaste
markj

Summary

If we get EOPNOTSUPP from open() failing, then it may just be that we're
looking at a unix(4) socket instead of a normal file/device or whatnot.
Fallback to trying to open it as a unix(4) socket, which is a useful
feature that doesn't add much complexity.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61326
Build 58210: arc lint + arc unit

Event Timeline

kevans created this revision.Tue, Dec 24, 10:30 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Dec 24, 10:30 PM

kevans requested review of this revision.Tue, Dec 24, 10:30 PM

Harbormaster completed remote builds in B61323: Diff 148379.Tue, Dec 24, 10:30 PM

kevans added a parent revision: D48196: tee: minor cleanup.Tue, Dec 24, 10:30 PM

I'd like to look at incorporating something like https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=117733, too, though the patch isn't available anymore.

Should we mention this in the man page? Not sure it's necessary, but if this is something that other tee implementations don't do, or something that they document, we ought to.

Add a note to the manpage that we'll also accept UNIX sockets. No other
implementation that I looked at seems to do this, but it would be handy.

Harbormaster completed remote builds in B61326: Diff 148384.Wed, Dec 25, 4:42 AM

des accepted this revision.Thu, Dec 26, 1:36 PM

This revision is now accepted and ready to land.Thu, Dec 26, 1:36 PM

markj accepted this revision.Sat, Dec 28, 4:53 PM

markj added inline comments.