column(1): add tests
Needs RevisionPublic
Actions

Authored by ivy on Sat, Apr 19, 9:11 AM.

Details

Reviewers

kevans
des

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63607
Build 60491: arc lint + arc unit

Event Timeline

ivy created this revision.Sat, Apr 19, 9:11 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Apr 19, 9:11 AM

ivy requested review of this revision.Sat, Apr 19, 9:11 AM

Harbormaster completed remote builds in B63592: Diff 153912.Sat, Apr 19, 9:11 AM

you may notice this commit does not include tests for column -t. this is deliberate as i found a bug in column -t and plan to add a new feature, a bug fix, and a test as a follow-up commit.

des requested changes to this revision.Sat, Apr 19, 10:33 AM

des added inline comments.

usr.bin/column/tests/column.sh
21	This should go in the test body, not in the head. The head is for setting ATF variables and such.
51
52	`-s exit 0` is implied.
57	This is unnecessary. Each test is run in a separate temporary directory which is deleted after completion, regardless of outcome.

This revision now requires changes to proceed.Sat, Apr 19, 10:33 AM

add test descriptions
don't remove files in cleanup
create test data in body, not head
remove -s exit:0 as it's redundant
use atf_check -o output:save instead of manual redirection

Harbormaster completed remote builds in B63607: Diff 153980.Sun, Apr 20, 8:04 PM

NB, i also removed a test line from the colonic_table test (the one with a single : and empty fields) because it currently fails, a fix for this bug will be part of a follow-up commit.

des requested changes to this revision.Mon, Apr 21, 5:28 PM

des added inline comments.

usr.bin/column/Makefile
4	sorry I missed this

This revision now requires changes to proceed.Mon, Apr 21, 5:28 PM

des added inline comments.Mon, Apr 21, 5:29 PM

etc/mtree/BSD.tests.dist
1090 ↗	(On Diff #153912)	why did you drop this when you updated the patch?
usr.bin/column/Makefile
1	required for `${MK_TESTS}` to be defined prior to including `<bsd.prog.mk>`