usb: serial: propagate errors from ucom_queue_command()
ClosedPublic
Actions

Authored by kevans on Dec 6 2024, 10:01 PM.

Details

Reviewers

imp
kib

Commits

rG51f3d0874f62: usb: serial: propagate errors from ucom_queue_command()

Summary

There's only one error that we can get back right now, but future
changes will add some more cases that we need to watch out for. Start
by returning errors and propagating them back.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60991
Build 57875: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Dec 6 2024, 10:01 PM

kevans created this revision.

Harbormaster completed remote builds in B60991: Diff 147623.Dec 6 2024, 10:01 PM

kevans added a child revision: D47951: usb: serial: allow the open/close sleep to be interruptible.Dec 6 2024, 10:01 PM

kevans mentioned this in D24459: (WIP) tty: split the tty lock up, make the primary tty lock sleepable.Dec 6 2024, 10:04 PM

kenrap_kennethraplee.com added a subscriber: kenrap_kennethraplee.com.Dec 6 2024, 10:19 PM

kib added inline comments.Dec 7 2024, 2:39 AM

sys/dev/usb/serial/usb_serial.c
809	Why return ENOTTY and then translate the error?

kevans added inline comments.Dec 7 2024, 3:40 AM

sys/dev/usb/serial/usb_serial.c
809	Will fix- originally this bubbled up to ucom_ioctl as well, where it didn't get translated. Later revisions added `ucom_command_barrier` which will get used in some contexts where ENOTTY makes sense for the tty layer (ioctl) and others where ENXIO makes more sense.