I spot checked a few, they looked good.
The Linux folks use coccinelle https://en.wikipedia.org/wiki/Coccinelle_(software) to mechanically do these sorts of transformations and publish the script used.

This revision is now accepted and ready to land.Nov 21 2024, 10:43 PM

The Linux folks use coccinelle

Yeah it would be great to have coccinelle for downstream projects to apply the same change in derived repos.

In D47675#1087881, @emaste wrote:

The Linux folks use coccinelle

Yeah it would be great to have coccinelle for downstream projects to apply the same change in derived repos.

Both of these were not fully automatable since the new functions return void instead of always returning 0, so you have to fix places that were checking for an error. That said, I just used sed -i -e 's/bus_generic_attach/bus_attach_children/g' and then fixed the errors for places that were checking for error.

Closed by commit rG18250ec6c089: Replace calls to bus_generic_attach with bus_attach_children (authored by jhb). · Explain WhyDec 18 2024, 6:30 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG18250ec6c089: Replace calls to bus_generic_attach with bus_attach_children.

Large Diff

This large diff affects 270 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

sys/

amd64/

acpica/

acpi_machdep.c

3 lines

arm/

allwinner/

aw_rsb.c

2 lines

annapurna/

alpine/

alpine_pci_msix.c

3 lines

arm/

gic_acpi.c

2 lines

gic_fdt.c

2 lines

nexus.c

2 lines

broadcom/

bcm2835/

3 lines

3 lines

2 lines

2 lines

3 lines

3 lines

freescale/

vybrid/

vf_spi.c

3 lines

mv/

3 lines

3 lines

3 lines

3 lines

nvidia/

as3722.c

3 lines

drm2/

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

2 lines

3 lines

qualcomm/

ipq4018_usb_hs_phy.c

3 lines

ipq4018_usb_ss_phy.c

3 lines

ti/

am335x/

am335x_ehrpwm.c

3 lines

am335x_pwmss.c

3 lines

am335x_usb_phy.c

3 lines

clk/

3 lines

9 lines

9 lines

9 lines

9 lines

cpsw/

2 lines

3 lines

4 lines

3 lines

3 lines

2 lines

3 lines

8 lines

twl/

twl.c

3 lines

usb/

omap_host.c

3 lines

arm64/

gic_v3_acpi.c

2 lines

gic_v3_fdt.c

3 lines

nexus.c

2 lines

broadcom/

brcmmdio/

mdio_mux_iproc.c

3 lines

mdio_nexus_iproc.c

3 lines

mdio_ns2_pcie_phy.c

3 lines

cavium/

thunder_pcie_pem.c

4 lines

nvidia/

tegra210/

max77620.c

3 lines

max77620_rtc.c

3 lines

qoriq/

qoriq_dw_pci.c

3 lines

qoriq_therm.c

3 lines

rockchip/

3 lines

3 lines

3 lines

3 lines

3 lines

compat/

linuxkpi/

common/

src/

linux_i2c.c

11 lines

linux_i2cbb.c

11 lines

contrib/

vchiq/

interface/

vchiq_arm/

vchiq_kmod.c

2 lines

dev/

aac/

aac.c

7 lines

aacraid/

aacraid.c

4 lines

acpi_support/

acpi_wmi.c

2 lines

acpica/

4 lines

3 lines

2 lines

3 lines

adb/

adb_bus.c

2 lines

ahci/

ahci.c

2 lines

alpm/

alpm.c

2 lines

amdpm/

amdpm.c

2 lines

amdsmb/

amdsmb.c

2 lines

ata/

ata-pci.c

2 lines

chipsets/

ata-jmicron.c

2 lines

ata-marvell.c

2 lines

atkbdc/

atkbdc_isa.c

2 lines

atopcase/

atopcase.c

3 lines

bhnd/

bhndb/

bhndb_pci.c

3 lines

cores/

chipc/

chipc.c

5 lines

chipc_spi.c

3 lines

pci/

bhnd_pci.c

10 lines

pcie2/

bhnd_pcie2.c

10 lines

cfi/

cfi_core.c

2 lines

clk/

allwinner/

aw_ccu.c

3 lines

clk_bus.c

3 lines

clk_fixed.c

3 lines

cxgb/

cxgb_main.c

3 lines

cxgbe/

t4_main.c

9 lines

t4_vf.c

7 lines

dpaa/

bman_portals.c

3 lines

fman.c

3 lines

qman_portals.c

3 lines

dpaa2/

dpaa2_mc.c

2 lines

dpaa2_rc.c

17 lines

memac_mdio_acpi.c

2 lines

drm2/

drm_dp_iic_helper.c

2 lines

dwwdt/

dwwdt.c

3 lines

etherswitch/

ar40xx/

ar40xx_main.c

2 lines

arswitch/

arswitch.c

7 lines

e6000sw/

e6000sw.c

2 lines

e6060sw.c

4 lines

felix/

felix.c

2 lines

infineon/

adm6996fc.c

4 lines

ip17x/

ip17x.c

4 lines

micrel/

ksz8995ma.c

4 lines

miiproxy.c

13 lines

mtkswitch/

mtkswitch.c

5 lines

rtl8366/

rtl8366rb.c

4 lines

ukswitch/

ukswitch.c

4 lines

fdc/

fdc.c

5 lines

fdc_acpi.c

3 lines

fdt/

simple_mfd.c

3 lines

simplebus.c

3 lines

firewire/

firewire.c

2 lines

fwohci_pci.c

2 lines

firmware/

arm/

scmi.c

4 lines

xilinx/

zynqmp_firmware.c

3 lines

flash/

cqspi.c

2 lines

gpio/

dwgpio/

3 lines

7 lines

3 lines

3 lines

3 lines

hid/

hidbus.c

7 lines

hyperv/

input/

hv_hid.c

4 lines

pcib/

vmbus_pcib.c

2 lines

vmbus/

vmbus.c

2 lines

ichiic/

ig4_iic.c

6 lines

ida/

ida.c

2 lines

iicbus/

controller/

opencores/

iicoc_pci.c

2 lines

rockchip/

rk_i2c.c

2 lines

twsi/

twsi.c

2 lines

vybrid/

2 lines

2 lines

2 lines

7 lines

2 lines

mux/

2 lines

2 lines

2 lines

2 lines

3 lines

pmic/

act8846.c

3 lines

imcsmb/

imcsmb.c

5 lines

imcsmb_pci.c

6 lines

ips/

ips.c

4 lines

ismt/

ismt.c

6 lines

mdio/

mdio.c

3 lines

mfi/

mfi.c

6 lines

mge/

if_mge.c

2 lines

mii/

mii.c

11 lines

mlx/

mlx.c

5 lines

mmc/

mmc.c

2 lines

msk/

if_msk.c

6 lines

mvs/

mvs_pci.c

2 lines

mvs_soc.c

2 lines

neta/

if_mvneta.c

4 lines

nfsmb/

nfsmb.c

4 lines

ntb/

ntb.c

2 lines

ntb_transport.c

2 lines

nvdimm/

nvdimm_acpi.c

4 lines

ofw/

6 lines

3 lines

3 lines

3 lines

ow/

ow.c

3 lines

p2sb/

lewisburg_gpiocm.c

3 lines

p2sb.c

3 lines

pcf/

pcf_isa.c

2 lines

pci/

controller/

3 lines

2 lines

3 lines

3 lines

pci_host_generic_acpi.c

3 lines

pci_host_generic_den0115.c

3 lines

pci_host_generic_fdt.c

3 lines

pci_iov.c

2 lines

pci_pci.c

5 lines

vga_pci.c

2 lines

ppbus/

ppbconf.c

2 lines

psci/

psci.c

2 lines

smccc.c

3 lines

pst/

pst-pci.c

3 lines

pwm/

controller/

allwinner/

aw_pwm.c

3 lines

rockchip/

rk_pwm.c

3 lines

ofw_pwmbus.c

3 lines

pwmbus.c

3 lines

qcom_dwc3/

qcom_dwc3.c

3 lines

qcom_qup/

qcom_spi.c

3 lines

regulator/

regulator_bus.c

3 lines

regulator_fixed.c

9 lines

sdhci/

fsl_sdhci.c

2 lines

sdhci_fsl_fdt.c

3 lines

siis/

siis.c

2 lines

sk/

if_sk.c

6 lines

smbus/

smbus.c

2 lines

sound/

pci/

csa.c

2 lines

emu10kx.c

3 lines

fm801.c

2 lines

hda/

4 lines

2 lines

2 lines

3 lines

4 lines

usb/

uaudio.c

5 lines

spibus/

controller/

allwinner/

aw_spi.c

3 lines

rockchip/

rk_spi.c

3 lines

ofw_spibus.c

3 lines

spibus.c

3 lines

sram/

mmio_sram.c

3 lines

superio/

superio.c

2 lines

syscon/

syscon_generic.c

3 lines

usb/

controller/

dwc3/

aw_dwc3.c

3 lines

rk_dwc3.c

3 lines

xlnx_dwc3.c

3 lines

input/

usbhid.c

7 lines

misc/

cp2112.c

2 lines

i2ctinyusb.c

2 lines

viapm/

viapm.c

4 lines

vmd/

vmd.c

3 lines

vnic/

mrml_bridge.c

3 lines

thunder_mdio_fdt.c

3 lines

xen/

bus/

xenpv.c

5 lines

pcifront/

pcifront.c

6 lines

xenstore/

xenstore.c

4 lines

xilinx/

axi_quad_spi.c

3 lines

i386/

acpica/

acpi_machdep.c

3 lines

isa/

isa_common.c

7 lines

vga_isa.c

4 lines

powerpc/

mambo/

mambo.c

3 lines

mpc85xx/

fsl_espi.c

4 lines

i2c.c

2 lines

lbc.c

3 lines

ofw/

ofw_pcibus.c

3 lines

powermac/

3 lines

3 lines

3 lines

3 lines

3 lines

6 lines

3 lines

powernv/

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

powerpc/

nexus.c

2 lines

ps3/

ps3bus.c

3 lines

pseries/

vdevice.c

3 lines

psim/

ata_iobus.c

3 lines

iobus.c

3 lines

riscv/

nexus.c

2 lines

riscv_console.c

2 lines

sifive/

fu740_pci_dw.c

3 lines

x86/

pci/

pci_bus.c

3 lines

qpi.c

6 lines

x86/

legacy.c

4 lines

mptable_pci.c

3 lines

nexus.c

2 lines

Replace calls to bus_generic_attach with bus_attach_childrenClosedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 148207

sys/amd64/acpica/acpi_machdep.c

sys/arm/allwinner/aw_rsb.c

sys/arm/annapurna/alpine/alpine_pci_msix.c

sys/arm/arm/gic_acpi.c

sys/arm/arm/gic_fdt.c

sys/arm/arm/nexus.c

sys/arm/broadcom/bcm2835/bcm2835_clkman.c

sys/arm/broadcom/bcm2835/bcm2835_pwm.c

sys/arm/broadcom/bcm2835/bcm2835_sdhci.c

sys/arm/broadcom/bcm2835/bcm2835_sdhost.c

sys/arm/broadcom/bcm2835/bcm2835_spi.c

sys/arm/broadcom/bcm2835/bcm2838_pci.c

sys/arm/freescale/vybrid/vf_spi.c

sys/arm/mv/a37x0_iic.c

sys/arm/mv/mv_pci.c

sys/arm/mv/mv_pci_ctrl.c

sys/arm/mv/mvebu_gpio.c

sys/arm/nvidia/as3722.c

sys/arm/nvidia/drm2/tegra_dc.c

sys/arm/nvidia/drm2/tegra_hdmi.c

sys/arm/nvidia/drm2/tegra_host1x.c

sys/arm/nvidia/tegra_abpmisc.c

sys/arm/nvidia/tegra_efuse.c

sys/arm/nvidia/tegra_gpio.c

sys/arm/nvidia/tegra_i2c.c

sys/arm/nvidia/tegra_mc.c

sys/arm/nvidia/tegra_pcie.c

sys/arm/nvidia/tegra_rtc.c

sys/arm/nvidia/tegra_sdhci.c

sys/arm/nvidia/tegra_soctherm.c

sys/arm/qualcomm/ipq4018_usb_hs_phy.c

sys/arm/qualcomm/ipq4018_usb_ss_phy.c

sys/arm/ti/am335x/am335x_ehrpwm.c

sys/arm/ti/am335x/am335x_pwmss.c

sys/arm/ti/am335x/am335x_usb_phy.c

sys/arm/ti/clk/ti_clkctrl.c

sys/arm/ti/clk/ti_divider_clock.c

sys/arm/ti/clk/ti_dpll_clock.c

sys/arm/ti/clk/ti_gate_clock.c

sys/arm/ti/clk/ti_mux_clock.c

sys/arm/ti/cpsw/if_cpsw.c

sys/arm/ti/ti_omap4_cm.c

sys/arm/ti/ti_prcm.c

sys/arm/ti/ti_scm.c

sys/arm/ti/ti_scm_syscon.c

sys/arm/ti/ti_sdhci.c

sys/arm/ti/ti_spi.c

sys/arm/ti/ti_sysc.c

sys/arm/ti/twl/twl.c

sys/arm/ti/usb/omap_host.c

sys/arm64/arm64/gic_v3_acpi.c

sys/arm64/arm64/gic_v3_fdt.c

sys/arm64/arm64/nexus.c

sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c

sys/arm64/broadcom/brcmmdio/mdio_nexus_iproc.c

sys/arm64/broadcom/brcmmdio/mdio_ns2_pcie_phy.c

sys/arm64/cavium/thunder_pcie_pem.c

sys/arm64/nvidia/tegra210/max77620.c

sys/arm64/nvidia/tegra210/max77620_rtc.c

sys/arm64/qoriq/qoriq_dw_pci.c

sys/arm64/qoriq/qoriq_therm.c

sys/arm64/rockchip/rk3568_pcie.c

sys/arm64/rockchip/rk_pcie.c

sys/arm64/rockchip/rk_pinctrl.c

sys/arm64/rockchip/rk_tsadc.c

sys/arm64/rockchip/rk_usbphy.c

sys/compat/linuxkpi/common/src/linux_i2c.c

sys/compat/linuxkpi/common/src/linux_i2cbb.c

sys/contrib/vchiq/interface/vchiq_arm/vchiq_kmod.c

sys/dev/aac/aac.c

sys/dev/aacraid/aacraid.c

sys/dev/acpi_support/acpi_wmi.c

sys/dev/acpica/acpi.c

Replace calls to bus_generic_attach with bus_attach_children
ClosedPublic
Actions

Revision Contents
Changeset List