Page MenuHomeFreeBSD

Add support for Nuvoton NCT6122D/NCT6126D.
AcceptedPublic

Authored by Matthew.Nygard.Dodd_gmail.com on Thu, Nov 14, 2:55 PM.
Tags
None
Referenced Files
F102831437: D47571.id146452.diff
Sun, Nov 17, 6:07 PM
F102830956: D47571.id146451.diff
Sun, Nov 17, 5:59 PM
F102819955: D47571.id146452.diff
Sun, Nov 17, 2:48 PM
F102816696: D47571.id146443.diff
Sun, Nov 17, 1:50 PM
F102811683: D47571.id.diff
Sun, Nov 17, 12:17 PM
F102809817: D47571.diff
Sun, Nov 17, 11:46 AM
F102804897: D47571.diff
Sun, Nov 17, 10:05 AM
F102804875: D47571.id146443.diff
Sun, Nov 17, 10:04 AM

Details

Reviewers
imp
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Add support for Nuvoton NCT6122D/NCT6126D - superio(9), nctgpio(9), ncthwm(9)

  • GPIO for LDN 7 & 9.
  • HWM for LDN 11
  • Provide LDN based matching for GPIO devices.
  • Provide gpio(9) hint flag (NCT_NO_ENABLE) for skipping GPIO enable, to avoid altering BIOS setting.
  • Allocate GPIO ioports as shareable.
  • Constrain mask based matching for existing NCT6112D/NCT6114D/NCT6116D.
Test Plan

Tested on Asus N97T-IM-A:

(dmesg output)
superio0: <Nuvoton NCT6122D/NCT6126D> at port 0x2e-0x2f on isa0
gpio0: <GPIO on Nuvoton NCT6122D/NCT6126D> at GPIO ldn 0x07 on superio0
gpio0: skipping enable.
gpiobus0: <GPIO bus> on gpio0
gpioc0: <GPIO controller> on gpio0
gpio1: <GPIO on Nuvoton NCT6122D/NCT6126D> at GPIO ldn 0x09 on superio0
gpio1: skipping enable.
gpiobus1: <GPIO bus> on gpio1
gpioc1: <GPIO controller> on gpio1
ncthwm0: <HWM on Nuvoton NCT6122D/NCT6126D> at HWM ldn 0x0b on superio0

(sysctl)
dev.ncthwm.0.AUXFAN2: 0
dev.ncthwm.0.AUXFAN1: 0
dev.ncthwm.0.AUXFAN0: 0
dev.ncthwm.0.CPUFAN: 0
dev.ncthwm.0.SYSFAN: 796

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Owners added a reviewer: Restricted Owners Package.Thu, Nov 14, 2:55 PM

If you have added this from a diff, could you please re-do the diff with -U 9999 option?
That's to have a lot more context lines which would be useful when reviewing.

In D47571#1084984, @avg wrote:

If you have added this from a diff, could you please re-do the diff with -U 9999 option?
That's to have a lot more context lines which would be useful when reviewing.

Done.

In D47571#1084984, @avg wrote:

If you have added this from a diff, could you please re-do the diff with -U 9999 option?
That's to have a lot more context lines which would be useful when reviewing.

Done.

Phabricator still tells me "Context not available".

This seems good to my eye...
Do you need someone to commit it?

This revision is now accepted and ready to land.Sat, Nov 16, 6:10 AM
In D47571#1086063, @imp wrote:

This seems good to my eye...
Do you need someone to commit it?

My commit bit has been inactive for years so yea, probably. :)