Page MenuHomeFreeBSD
Differential D47283

arm64: Use the common activate function in nexus
ClosedPublic
Actions

Authored by andrew on Fri, Oct 25, 2:20 PM.
Tags
None
Referenced Files
F102010399: D47283.diff
Wed, Nov 6, 12:34 PM
Unknown Object (File)
Sat, Nov 2, 11:04 AM
Unknown Object (File)
Fri, Nov 1, 12:32 PM
Unknown Object (File)
Fri, Nov 1, 12:32 PM
Unknown Object (File)
Fri, Nov 1, 12:31 PM
Unknown Object (File)
Fri, Nov 1, 12:27 PM
Unknown Object (File)
Tue, Oct 29, 10:37 AM
Unknown Object (File)
Tue, Oct 29, 6:22 AM
View All 9 Files
Subscribers
emaste
imp
mmel

Details

Reviewers
jhb
cperciva
manu
Group Reviewers
arm64
Commits
rG60344d7e09d5: arm64: Use the common activate function in nexus
Summary

For non-memory and non-ioport spaces use the common
bus_generic_rman_activate_resource function in the arm64 nexus. We
can't currently use it for memory types as it doesn't support
non-posted memory.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60190
Build 57074: arc lint + arc unit

Event Timeline

andrew created this revision.Fri, Oct 25, 2:20 PM
Herald added a reviewer: manu. · View Herald TranscriptFri, Oct 25, 2:20 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Fri, Oct 25, 2:20 PM
andrew added a parent revision: D47282: bus: Activate INTRNG interrupts in common code.
Harbormaster completed remote builds in B60190: Diff 145457.Fri, Oct 25, 2:20 PM
andrew added a reviewer: arm64.Fri, Oct 25, 2:20 PM
jhb accepted this revision.Fri, Oct 25, 4:21 PM

Is the same change needed for nexus drivers on other INTRNG platforms? I guess it isn't required, per se, but it is a nice cleanup to reduce duplicated code?

This revision is now accepted and ready to land.Fri, Oct 25, 4:21 PM
andrew added a comment.Fri, Oct 25, 4:35 PM

I think the other drivers can use bus_generic_rman_activate_resource directly, however I can't easily test them.

cperciva added a comment.Fri, Oct 25, 5:03 PM

Should I be testing this on Graviton (with my _AEI patches minus the bogus resource activation one)?

mmel added a subscriber: mmel.Fri, Oct 25, 5:10 PM

+1 for deduplication

sys/arm64/arm64/nexus.c
362

Isn't removing intr_activate_irq() a mistake? I can't find who calls it after the patch...

andrew added a comment.Fri, Oct 25, 5:16 PM
In D47283#1078259, @cperciva wrote:

Should I be testing this on Graviton (with my _AEI patches minus the bogus resource activation one)?

This one is optional, it's a cleanup after merging common code.

sys/arm64/arm64/nexus.c
362

See D47282

Closed by commit rG60344d7e09d5: arm64: Use the common activate function in nexus (authored by andrew). · Explain WhyTue, Oct 29, 10:35 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG60344d7e09d5: arm64: Use the common activate function in nexus.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
37 lines

Diff 145457

View Options

sys/arm64/arm64/nexus.c

Loading...