Page MenuHomeFreeBSD
Differential D47155

device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails
ClosedPublic
Actions

Authored by jhb on Wed, Oct 16, 3:27 PM.
Tags
None
Referenced Files
F102016470: D47155.diff
Wed, Nov 6, 2:24 PM
F102012341: D47155.diff
Wed, Nov 6, 1:10 PM
Unknown Object (File)
Tue, Oct 29, 10:54 PM
Unknown Object (File)
Thu, Oct 24, 11:57 PM
Unknown Object (File)
Tue, Oct 22, 11:36 AM
Unknown Object (File)
Sun, Oct 20, 9:37 PM
Unknown Object (File)
Sun, Oct 20, 9:37 PM
Unknown Object (File)
Sun, Oct 20, 9:37 PM
View All 11 Files
Subscribers
olce

Details

Reviewers
imp
Commits
rG42078dfb0f72: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails
Summary

This gives the parent bus driver the opportunity to cleanup any
allocated resources, etc. left behind by a failed attach attempt.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Wed, Oct 16, 3:27 PM
Herald added a subscriber: olce. · View Herald TranscriptWed, Oct 16, 3:27 PM
jhb requested review of this revision.Wed, Oct 16, 3:27 PM
Harbormaster completed remote builds in B60042: Diff 144995.Wed, Oct 16, 3:27 PM
jhb added a parent revision: D47154: device_delete_child: Update comments.Wed, Oct 16, 3:27 PM
jhb added a child revision: D47156: bus_generic_detach: Remove redundant check.
imp accepted this revision.Wed, Oct 16, 3:34 PM

So long as the parent doesn't call the child's detach, this is great. I'm pretty sure this is the case, but we need to make sure there's no double freeing introduced

This revision is now accepted and ready to land.Wed, Oct 16, 3:34 PM
jhb added a comment.Wed, Oct 16, 6:06 PM

I don't think the parent can interfere here as DEVICE_ATTACH calls the child method directly without giving the parent driver a chance to interpose.

Closed by commit rG42078dfb0f72: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails (authored by jhb). · Explain WhyWed, Oct 16, 6:11 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG42078dfb0f72: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails.

Revision Contents
Changeset List

PathSize
sys/
kern/
1 line

Diff 145006

View Options

sys/kern/subr_bus.c

Loading...