device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails
ClosedPublic
Actions

Authored by jhb on Wed, Oct 16, 3:27 PM.

Details

Reviewers

Commits

rG42078dfb0f72: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails

Summary

This gives the parent bus driver the opportunity to cleanup any
allocated resources, etc. left behind by a failed attach attempt.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60042
Build 56926: arc lint + arc unit

Event Timeline

jhb created this revision.Wed, Oct 16, 3:27 PM

Herald added a subscriber: olce. · View Herald TranscriptWed, Oct 16, 3:27 PM

jhb requested review of this revision.Wed, Oct 16, 3:27 PM

Harbormaster completed remote builds in B60042: Diff 144995.Wed, Oct 16, 3:27 PM

jhb added a parent revision: D47154: device_delete_child: Update comments.Wed, Oct 16, 3:27 PM

jhb added a child revision: D47156: bus_generic_detach: Remove redundant check.

So long as the parent doesn't call the child's detach, this is great. I'm pretty sure this is the case, but we need to make sure there's no double freeing introduced

This revision is now accepted and ready to land.Wed, Oct 16, 3:34 PM

I don't think the parent can interfere here as DEVICE_ATTACH calls the child method directly without giving the parent driver a chance to interpose.

Closed by commit rG42078dfb0f72: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails (authored by jhb). · Explain WhyWed, Oct 16, 6:11 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG42078dfb0f72: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails.

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_bus.c

1 line

Diff 144995

View Options

device_attach: Invoke BUS_CHILD_DETACHED if an attach routine failsClosedPublicActions