uart/ns8250: Factor out reading the divisor
ClosedPublic
Actions

Authored by imp on Oct 11 2024, 9:53 PM.

Tags

None

Referenced Files

	F108593895: D47074.id144678.diff
	Sun, Jan 26, 6:13 PM

	Unknown Object (File)
	Tue, Jan 14, 5:13 PM

	Unknown Object (File)
	Sun, Jan 12, 8:17 PM

	Unknown Object (File)
	Dec 18 2024, 7:34 PM

	Unknown Object (File)
	Dec 18 2024, 4:38 PM

	Unknown Object (File)
	Dec 18 2024, 7:15 AM

	Unknown Object (File)
	Dec 8 2024, 9:09 PM

	Unknown Object (File)
	Dec 7 2024, 7:53 PM

View All 24 Files

Subscribers

None

Details

Reviewers

markj
andrew
adrian
jhb
jrtc27
bz
marius
oh
manu
kevans
cperciva
mhorne
mw
mmel

Commits

rG4097cd06ca49: uart/ns8250: Factor out reading the divisor

Summary

We have two copies (soon to be three) of reading the divisor. Since it's
a complicated tricky process, abstract it to its own routine.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59921
Build 56806: arc lint + arc unit

Event Timeline

imp requested review of this revision.Oct 11 2024, 9:53 PM

imp created this revision.

Harbormaster completed remote builds in B59921: Diff 144678.Oct 11 2024, 9:53 PM

imp added a parent revision: D47073: uart/ns8250: Tweak printfs to always prefix messages with uart:.Oct 11 2024, 9:53 PM

imp added a child revision: D47075: uart/ns8250: Disable interrupts sooner.

markj accepted this revision.Oct 12 2024, 2:52 PM

This revision is now accepted and ready to land.Oct 12 2024, 2:52 PM

andrew accepted this revision.Oct 14 2024, 9:28 AM

Closed by commit rG4097cd06ca49: uart/ns8250: Factor out reading the divisor (authored by imp). · Explain WhyOct 14 2024, 10:18 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG4097cd06ca49: uart/ns8250: Factor out reading the divisor.

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

uart_dev_ns8250.c

27 lines

Diff 144678

View Options

sys/dev/uart/uart_dev_ns8250.c

uart/ns8250: Factor out reading the divisorClosedPublicActions