Differential D47013

nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials
AcceptedPublic
Actions

Authored by olce on Oct 8 2024, 1:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 22, 6:33 PM

	Unknown Object (File)
	Mon, Oct 14, 4:11 PM

	Unknown Object (File)
	Fri, Oct 11, 2:25 AM

	Unknown Object (File)
	Wed, Oct 9, 7:05 PM

Subscribers

Details

Reviewers

Summary

There is no technical reason to limit that to NGROUPS_MAX, which is off
by one and just our minimum maximum value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59844
Build 56729: arc lint + arc unit

Event Timeline

olce created this revision.Oct 8 2024, 1:47 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 8 2024, 1:47 PM

olce requested review of this revision.Oct 8 2024, 1:47 PM

Harbormaster completed remote builds in B59844: Diff 144488.Oct 8 2024, 1:47 PM

olce added a parent revision: D46921: mountd(8): parsecred(): Groups limit: NGROUPS_MAX => NGROUPS_MAX + 1.Oct 8 2024, 1:47 PM

olce added a child revision: D47014: mountd(8): parsecred(): Remove comment on non-existent bug.Oct 8 2024, 1:48 PM

olce mentioned this in D46920: mountd(8): parsecred(): Remove "duplicate compression".Oct 8 2024, 2:43 PM

Looks fine to me, since ngroups_max can never
be set < NGROUPS_MAX.

This revision is now accepted and ready to land.Wed, Oct 9, 2:29 AM

olce mentioned this in D46921: mountd(8): parsecred(): Groups limit: NGROUPS_MAX => NGROUPS_MAX + 1.Mon, Oct 14, 3:11 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

Diff 144488

sys/kern/vfs_mount.c

Loading...