Page MenuHomeFreeBSD
Differential D46921

mountd(8): parsecred(): Groups limit: NGROUPS_MAX => NGROUPS_MAX + 1
Needs ReviewPublic
Actions

Authored by olce on Fri, Oct 4, 8:10 AM.

Details

Reviewers
rmacklem
Summary

Lift this unnecessary limitation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59732
Build 56618: arc lint + arc unit

Event Timeline

olce created this revision.Fri, Oct 4, 8:10 AM
Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 4, 8:10 AM
olce requested review of this revision.Fri, Oct 4, 8:10 AM
Harbormaster completed remote builds in B59732: Diff 144219.Fri, Oct 4, 8:11 AM
olce added a subscriber: bapt.Fri, Oct 4, 8:17 AM
olce added a parent revision: D46922: cred: proc_set_cred(): Remove obsolete comments.Fri, Oct 4, 8:30 AM
olce removed a parent revision: D46922: cred: proc_set_cred(): Remove obsolete comments.
olce added a parent revision: D46920: mountd(8): parsecred(): Remove "duplicate compression".Fri, Oct 4, 8:32 AM
emaste added a comment.Fri, Oct 4, 1:32 PM

Presumably this can be removed because getgrouplist will set ngroups at most NGROUPS_MAX, returning -1 if it would be too large (and ngroups was > NGROUPS_MAX on input). IMO we should replace this check with an assertion in that case as documentation.

Revision Contents
Changeset List

PathSize
usr.sbin/
mountd/
2 lines

Diff 144219

View Options

usr.sbin/mountd/mountd.c

Loading...