Page MenuHomeFreeBSD

rc.d/sendmail: Fix the rcorder block
ClosedPublic

Authored by 0mp on Oct 4 2024, 12:29 PM.
Tags
Referenced Files
F102071392: D46924.diff
Thu, Nov 7, 6:33 AM
F101992533: D46924.id144573.diff
Wed, Nov 6, 7:16 AM
Unknown Object (File)
Sun, Nov 3, 1:16 PM
Unknown Object (File)
Sun, Nov 3, 12:56 PM
Unknown Object (File)
Thu, Oct 17, 12:51 AM
Unknown Object (File)
Thu, Oct 17, 12:47 AM
Unknown Object (File)
Wed, Oct 16, 10:26 AM
Unknown Object (File)
Thu, Oct 10, 11:44 AM
Subscribers

Details

Summary

rcorder(8) requires the rcorder block to be an uninterrupted sequence of
REQUIRE, PROVIDE, BEFORE, and KEYWORD lines. Having a comment in between
REQUIRE and KEYWORD makes rcorder stop parsing the block when it reaches
the comment. Fix that by moving the comment out from the rcorder block.

MFC after: 3 days

Test Plan

After the patch is applied, rcorder will report sendmail as having the shutdown keyword:

rcorder -k shutdown /etc/rc.d/* | grep sendmail

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59737
Build 56623: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Oct 4 2024, 12:29 PM
0mp added reviewers: bnovkov, christos, markj.
0mp added a project: rc.

This seems fine to me. Looks like it's been broken for a rather long time.

What exactly is the effect? Does sendmail actually need the shutdown keyword?

This revision is now accepted and ready to land.Wed, Oct 9, 3:20 PM

What exactly is the effect? Does sendmail actually need the shutdown keyword?

Yes, to ensure a clean shutdown of active SMTP connections (and writing any in memory queue files).

What exactly is the effect? Does sendmail actually need the shutdown keyword?

Yes, to ensure a clean shutdown of active SMTP connections (and writing any in memory queue files).

Great info! Thanks!