mountd(8): parsecred(): Groups limit: NGROUPS_MAX => NGROUPS_MAX + 1

[olce]

Summary

Lift this unnecessary limitation.

[emaste]

Presumably this can be removed because getgrouplist will set ngroups at most NGROUPS_MAX, returning -1 if it would be too large (and ngroups was > NGROUPS_MAX on input). IMO we should replace this check with an assertion in that case as documentation.

[rmacklem]

usr.sbin/mountd/mountd.c

3653

Taking this out breaks the code. Note that ngroups is
set to NGROUPS_MAX + 1, so it is possible that it is
still NGROUPS_MAX+1.

If you are going to remove the code that takes out the
duplicate (that is another patch you presented and I will
comment on it there), then line#3648 should set

ngroups = NGROUPS_MAX

and

gid_t groups[NGROUPS_MAX];

However, this should only be done if the other patch
has been applied.