cred: Separate constant for the number of inlined groups
ClosedPublic
Actions

Authored by olce on Oct 4 2024, 8:07 AM.

Details

Reviewers

mhorne
mjg
emaste

Commits

rG3ce5ef4f7a97: cred: Separate constant for the number of inlined groups
rG350e2b1940df: cred: Separate constant for the number of inlined groups
rG664b9fcb1c05: cred: Separate constant for the number of inlined groups

Summary

CRED_SMALLGROUPS_NB now holds the number of inlined groups in field
'cr_smallgroups'. XU_NGROUPS stays the number of groups allowed in
'struct xucred'. The first is an implementation detail, while the
second is part of a public interface. All mentions of XU_NGROUPS in the
tree have been reviewed and only those concerning the implementation
detail have been changed to use CRED_SMALLGROUPS_NB (they were all in
'kern_prot.c').

No functional change (intended).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59722
Build 56608: arc lint + arc unit

Event Timeline

olce created this revision.Oct 4 2024, 8:07 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 4 2024, 8:07 AM

olce requested review of this revision.Oct 4 2024, 8:07 AM

Harbormaster completed remote builds in B59722: Diff 144209.Oct 4 2024, 8:07 AM

olce added a subscriber: bapt.Oct 4 2024, 8:17 AM

olce added a parent revision: D46910: cred: crget(): Compute initial 'cr_agroups' with nitems().Oct 4 2024, 8:30 AM

olce added a child revision: D46912: cred: kern_setgroups(): Internally use int as number of groups' type.

Seems good. This is just a correctness change, yes? As in, CRED_SMALLGROUPS_NB is not touched by any later change in the series?

This revision is now accepted and ready to land.Oct 28 2024, 5:17 PM

In D46911#1078947, @mhorne wrote:

Seems good. This is just a correctness change, yes? As in, CRED_SMALLGROUPS_NB is not touched by any later change in the series?

Yes, this is effectively a correctness fix, with also the aim of enabling a possible increase of CRED_SMALLGROUPS_NB in the future (whereas XU_NGROUPS can't be changed because of backwards compatibility), although for now I don't feel a particular need to do it.

Closed by commit rG664b9fcb1c05: cred: Separate constant for the number of inlined groups (authored by olce). · Explain WhyNov 2 2024, 8:39 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG664b9fcb1c05: cred: Separate constant for the number of inlined groups.

olce added a commit: rG350e2b1940df: cred: Separate constant for the number of inlined groups.Nov 15 2024, 10:49 AM

olce added a commit: rG3ce5ef4f7a97: cred: Separate constant for the number of inlined groups.Nov 15 2024, 1:01 PM