Page MenuHomeFreeBSD
Differential D46906

cred: supplementary_group_member() => group_is_supplementary()
ClosedPublic
Actions

Authored by olce on Oct 4 2024, 8:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 12:07 AM
Unknown Object (File)
Fri, Jan 3, 1:46 AM
Unknown Object (File)
Wed, Dec 25, 2:37 PM
Unknown Object (File)
Tue, Dec 24, 11:29 AM
Unknown Object (File)
Sun, Dec 22, 5:10 PM
Unknown Object (File)
Dec 9 2024, 1:00 AM
Unknown Object (File)
Nov 28 2024, 7:02 PM
Unknown Object (File)
Nov 26 2024, 9:56 PM
View All 22 Files
Subscribers
bapt
imp

Details

Reviewers
mhorne
mjg
emaste
olce
Commits
rG9d0d6174840a: cred: supplementary_group_member() => group_is_supplementary()
rG3db3a7617b82: cred: supplementary_group_member() => group_is_supplementary()
rG2e031fd0719b: cred: supplementary_group_member() => group_is_supplementary()
Summary

The new name seems more immediately descriptive.

While here, replace "supplemental" => "supplementary" in some comments.

No functional change (intended).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Oct 4 2024, 8:07 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 4 2024, 8:07 AM
olce requested review of this revision.Oct 4 2024, 8:07 AM
Harbormaster completed remote builds in B59717: Diff 144204.Oct 4 2024, 8:07 AM
olce added a subscriber: bapt.Oct 4 2024, 8:17 AM
olce added a child revision: D46907: cred: group_is_supplementary(): Use bsearch().Oct 4 2024, 8:30 AM
mhorne accepted this revision.Oct 4 2024, 2:49 PM

Or, group_is_supplimentary()?

This revision is now accepted and ready to land.Oct 4 2024, 2:49 PM
emaste added a comment.Oct 4 2024, 3:01 PM

Yeah, if group_is_supplimentary(gid, cred) reads clearly to me

olce added a comment.Oct 7 2024, 10:17 AM

Yes, you're right, renaming it.

mhorne mentioned this in D46908: cred: Make group_is_supplementary() public; New group_is_primary().Oct 7 2024, 7:11 PM
olce updated this revision to Diff 144482.Oct 8 2024, 1:28 PM
olce retitled this revision from cred: supplementary_group_member() => is_a_supplementary_group() to cred: supplementary_group_member() => group_is_supplementary().
olce edited the summary of this revision. (Show Details)

Rename to group_is_supplementary() instead.

This revision now requires review to proceed.Oct 8 2024, 1:28 PM
Harbormaster completed remote builds in B59838: Diff 144482.Oct 8 2024, 1:28 PM
olce accepted this revision.Oct 28 2024, 10:15 AM

Re-validating to note @mhorne's review as my last upload transitioned the change to "needs review" again.

This revision is now accepted and ready to land.Oct 28 2024, 10:15 AM
olce edited child revisions, added: D47343: cred: Constify signature of groupmember() and realgroupmember(); removed: D46907: cred: group_is_supplementary(): Use bsearch().Oct 30 2024, 6:30 PM
emaste accepted this revision.Nov 2 2024, 3:06 PM
Closed by commit rG2e031fd0719b: cred: supplementary_group_member() => group_is_supplementary() (authored by olce). · Explain WhyNov 2 2024, 8:39 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG2e031fd0719b: cred: supplementary_group_member() => group_is_supplementary().
olce added a commit: rG3db3a7617b82: cred: supplementary_group_member() => group_is_supplementary().Nov 15 2024, 10:49 AM
olce added a commit: rG9d0d6174840a: cred: supplementary_group_member() => group_is_supplementary().Nov 15 2024, 1:01 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
12 lines

Diff 145896

View Options

sys/kern/kern_prot.c

Loading...