Page MenuHomeFreeBSD
Differential D46417

lib/libc/aarch64/string: strcat enable use of SIMD
AcceptedPublic
Actions

Authored by getz on Aug 23 2024, 11:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 3:18 AM
Unknown Object (File)
Sun, Nov 3, 6:12 PM
Unknown Object (File)
Wed, Oct 23, 8:37 PM
Unknown Object (File)
Sun, Oct 20, 6:38 PM
Unknown Object (File)
Sun, Oct 20, 10:57 AM
Unknown Object (File)
Oct 16 2024, 10:01 AM
Unknown Object (File)
Oct 11 2024, 1:23 AM
Unknown Object (File)
Oct 8 2024, 2:20 PM
View All 38 Files
Subscribers
imp

Details

Reviewers
fuz
emaste
andrew
Summary

Call into SIMD strlen and stpcpy for an optimized strcat.
Port of D42600 for amd64.

Test Plan

Passes the strcat tests in the test suite

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59163
Build 56050: arc lint + arc unit

Event Timeline

getz created this revision.Aug 23 2024, 11:02 AM
Herald added a reviewer: andrew. · View Herald TranscriptAug 23 2024, 11:02 AM
Herald added a subscriber: imp. · View Herald Transcript
getz requested review of this revision.Aug 23 2024, 11:02 AM
Harbormaster completed remote builds in B59155: Diff 142369.Aug 23 2024, 11:02 AM
getz updated this revision to Diff 142370.Aug 23 2024, 11:05 AM
  • revert accidental edit of the makefile
Harbormaster completed remote builds in B59156: Diff 142370.Aug 23 2024, 11:05 AM
getz retitled this revision from lib/libc/aarch64/string: enable use of SIMD to lib/libc/aarch64/string: strcat enable use of SIMD.Aug 23 2024, 11:05 AM
fuz added a comment.Aug 23 2024, 1:52 PM

This is probably better done in C code. We don't do any fancy SIMD shenanigans here. The only reason I did it in assembly in D42600 is that the implementation shared a file with an optimised assembly implementation, so it couldn't be done in C.

Code looks ok.

getz added a comment.Aug 23 2024, 2:19 PM

alright, that makes sense. I'll replace it.

getz updated this revision to Diff 142386.Aug 23 2024, 5:37 PM

strcat in C instead of assembly

Harbormaster completed remote builds in B59163: Diff 142386.Aug 23 2024, 5:38 PM
andrew added a comment.Sep 22 2024, 6:13 PM

Could this be made machine independent?

fuz added a comment.Sep 23 2024, 9:16 AM

@andrew If we don't have assembly implementations for strlen and stpcpy, it's generally faster to implement this function directly.

fuz accepted this revision.Wed, Nov 6, 2:23 PM

exp-run says it's fine.

This revision is now accepted and ready to land.Wed, Nov 6, 2:23 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
string/
2 lines
20 lines

Diff 142386

View Options

lib/libc/aarch64/string/Makefile.inc

Loading...
View Options

lib/libc/aarch64/string/strcat.c

Loading...