Page MenuHomeFreeBSD
Differential D46292

lib/libc/aarch64/string: add strncat SIMD implementation
ClosedPublic
Actions

Authored by getz on Aug 14 2024, 2:12 PM.
Tags
None
Referenced Files
F108749624: D46292.id142444.diff
Mon, Jan 27, 5:07 PM
Unknown Object (File)
Thu, Jan 23, 6:52 PM
Unknown Object (File)
Fri, Jan 10, 6:58 PM
Unknown Object (File)
Sat, Jan 4, 3:02 AM
Unknown Object (File)
Dec 26 2024, 7:33 PM
Unknown Object (File)
Dec 25 2024, 8:30 PM
Unknown Object (File)
Dec 2 2024, 10:24 PM
Unknown Object (File)
Nov 30 2024, 6:23 AM
View All 35 Files
Subscribers
imp

Details

Reviewers
fuz
emaste
andrew
Commits
rG3dc5429158cf: lib/libc/aarch64/string: add strncat SIMD implementation
Summary

This patch requires D46170 as it depends on strlcpy being labeled
__memccpy.

It's a direct copy from the amd64 string functions.

Test Plan

Passes all tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

getz created this revision.Aug 14 2024, 2:12 PM
Herald added a reviewer: andrew. · View Herald TranscriptAug 14 2024, 2:12 PM
Herald added a subscriber: imp. · View Herald Transcript
getz requested review of this revision.Aug 14 2024, 2:12 PM
Harbormaster completed remote builds in B59018: Diff 142079.Aug 14 2024, 2:12 PM
getz added a parent revision: D46170: lib/libc/aarch64/string: add memccpy SIMD implementation.Aug 14 2024, 2:12 PM
fuz accepted this revision.Aug 14 2024, 5:11 PM

This looks reasonable.

This revision is now accepted and ready to land.Aug 14 2024, 5:11 PM
getz removed a parent revision: D46170: lib/libc/aarch64/string: add memccpy SIMD implementation.Aug 25 2024, 6:42 PM
getz updated this revision to Diff 142444.Aug 26 2024, 6:02 PM
  • fix Makefile
This revision now requires review to proceed.Aug 26 2024, 6:02 PM
Harbormaster completed remote builds in B59183: Diff 142444.Aug 26 2024, 6:02 PM
andrew added a comment.Sep 22 2024, 6:00 PM

Could this be made machine independent?

fuz added a comment.Sep 23 2024, 9:14 AM

@andrew If we don't have an assembly implementation for memccpy, it's generally faster to implement this function directly.

fuz accepted this revision.Nov 6 2024, 2:24 PM

exp-run says it's fine.

This revision is now accepted and ready to land.Nov 6 2024, 2:24 PM
Closed by commit rG3dc5429158cf: lib/libc/aarch64/string: add strncat SIMD implementation (authored by getz, committed by fuz). · Explain WhyFri, Jan 10, 3:04 PM
This revision was automatically updated to reflect the committed changes.
fuz added a commit: rG3dc5429158cf: lib/libc/aarch64/string: add strncat SIMD implementation.

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
string/
3 lines
29 lines

Diff 149061

View Options

lib/libc/aarch64/string/Makefile.inc

Loading...
View Options

lib/libc/aarch64/string/strncat.c

Loading...