Page MenuHomeFreeBSD

lib/libc/aarch64/string: add strncat SIMD implementation
AcceptedPublic

Authored by getz on Aug 14 2024, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 3:19 AM
Unknown Object (File)
Fri, Nov 8, 1:15 AM
Unknown Object (File)
Wed, Oct 30, 5:18 PM
Unknown Object (File)
Wed, Oct 30, 1:45 AM
Unknown Object (File)
Thu, Oct 24, 6:10 PM
Unknown Object (File)
Thu, Oct 17, 3:28 PM
Unknown Object (File)
Oct 11 2024, 1:23 AM
Unknown Object (File)
Oct 1 2024, 10:02 PM
Subscribers

Details

Reviewers
fuz
emaste
andrew
Summary

This patch requires D46170 as it depends on strlcpy being labeled
__memccpy.

It's a direct copy from the amd64 string functions.

Test Plan

Passes all tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59183
Build 56070: arc lint + arc unit

Event Timeline

getz requested review of this revision.Aug 14 2024, 2:12 PM

This looks reasonable.

This revision is now accepted and ready to land.Aug 14 2024, 5:11 PM
This revision now requires review to proceed.Aug 26 2024, 6:02 PM

Could this be made machine independent?

@andrew If we don't have an assembly implementation for memccpy, it's generally faster to implement this function directly.

exp-run says it's fine.

This revision is now accepted and ready to land.Wed, Nov 6, 2:24 PM