Page MenuHomeFreeBSD
Differential D46117

vm: Remove kernel stack swapping support, part 6
ClosedPublic
Actions

Authored by markj on Jul 24 2024, 9:39 PM.
Tags
None
Referenced Files
F102760976: D46117.diff
Sat, Nov 16, 7:27 PM
Unknown Object (File)
Wed, Nov 13, 9:56 PM
Unknown Object (File)
Thu, Nov 7, 8:49 AM
Unknown Object (File)
Sun, Nov 3, 12:16 PM
Unknown Object (File)
Thu, Oct 31, 12:06 AM
Unknown Object (File)
Oct 7 2024, 2:50 AM
Unknown Object (File)
Oct 2 2024, 12:54 PM
Unknown Object (File)
Sep 30 2024, 9:37 PM
View All 30 Files
Subscribers
emaste
imp
olce

Details

Reviewers
jhb
alc
kib
imp
Commits
rG472888018ce1: proc: Remove kernel stack swapping support, part 6
Summary
  • Remove most checks of the P_INMEM flag.
  • Some uses remain since a few userspace tools expect the flag to be set.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58815
Build 55702: arc lint + arc unit

Event Timeline

markj created this revision.Jul 24 2024, 9:39 PM
Herald added subscribers: olce, emaste, imp. · View Herald TranscriptJul 24 2024, 9:39 PM
markj requested review of this revision.Jul 24 2024, 9:39 PM
Harbormaster completed remote builds in B58815: Diff 141341.Jul 24 2024, 9:39 PM
markj added a parent revision: D46116: vm: Remove kernel stack swapping support, part 5.Jul 24 2024, 9:39 PM
markj added a child revision: D46118: vm: Remove kernel stack swapping support, part 7.
imp accepted this revision.Jul 24 2024, 9:51 PM

Can we document which processes/tools do that?

This revision is now accepted and ready to land.Jul 24 2024, 9:51 PM
markj added a comment.Jul 24 2024, 9:59 PM
In D46117#1051135, @imp wrote:

Can we document which processes/tools do that?

In the commit log message you mean? Sure. It's ps(1) and top(1) mainly, but I'm sure that code's been copy-pasted around.

kib added inline comments.Jul 25 2024, 10:49 AM
sys/fs/procfs/procfs_status.c
124

Could this be properly de-indented, please?

sys/kern/sys_process.c
99

IMO this macro should go away.

markj updated this revision to Diff 141373.Jul 25 2024, 1:59 PM
markj marked 2 inline comments as done.

Handle kib's comments.

This revision now requires review to proceed.Jul 25 2024, 1:59 PM
Harbormaster completed remote builds in B58826: Diff 141373.Jul 25 2024, 2:00 PM
kib accepted this revision.Jul 25 2024, 2:06 PM
This revision is now accepted and ready to land.Jul 25 2024, 2:06 PM
alc added inline comments.Jul 26 2024, 7:17 AM
sys/kern/sys_process.c
74

drop ()

markj marked an inline comment as done.Jul 26 2024, 12:59 PM
alc accepted this revision.Jul 27 2024, 12:17 AM
Closed by commit rG472888018ce1: proc: Remove kernel stack swapping support, part 6 (authored by markj). · Explain WhyJul 29 2024, 1:50 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG472888018ce1: proc: Remove kernel stack swapping support, part 6.

Revision Contents
Changeset List

PathSize
sys/
ddb/
10 lines
2 lines
7 lines
fs/
procfs/
5 lines
i386/
linux/
4 lines
kern/
5 lines
6 lines
8 lines
sys/
2 lines
2 lines
vm/
7 lines

Diff 141341

View Options

sys/ddb/db_command.c

Loading...
View Options

sys/ddb/db_ps.c

Loading...
View Options

sys/ddb/db_thread.c

Loading...
View Options

sys/fs/procfs/procfs_status.c

Loading...
View Options

sys/i386/linux/linux_ptrace_machdep.c

Loading...
View Options

sys/kern/kern_proc.c

Loading...
View Options

sys/kern/kern_racct.c

Loading...
View Options

sys/kern/sys_process.c

Loading...
View Options

sys/sys/proc.h

Loading...
View Options

sys/sys/user.h

Loading...
View Options

sys/vm/vm_swapout.c

Loading...