Page MenuHomeFreeBSD

loader: Bump all versions to 3.0
ClosedPublic

Authored by imp on Jul 5 2024, 8:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 3:03 AM
Unknown Object (File)
Sat, Oct 26, 6:17 AM
Unknown Object (File)
Sep 24 2024, 4:56 PM
Unknown Object (File)
Sep 21 2024, 5:17 AM
Unknown Object (File)
Sep 18 2024, 9:07 AM
Unknown Object (File)
Sep 12 2024, 2:58 AM
Unknown Object (File)
Sep 12 2024, 2:58 AM
Unknown Object (File)
Sep 8 2024, 5:29 PM

Details

Summary

Each incompatible change we make, we bump the major version. We've not
done the bump in a while, so sync everybody to 3.0. Anything older than
3.0 will be given a warning that their boot loader is too old. We check
only the major version, though, so minor versions can still be bumped
for individual loaders (though I honestly doubt we'll ever need to do
that again).

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 5 2024, 8:48 PM

I think "Universal version" may not age well. Maybe reference the modern LUA version you want to target that your earlier reverts are related to?

I think bumping everyone to 3.0 is fine. I did wonder about just using the major version going forward (e.g. 15 in main), but that's probably overkill and too many gratuitous versions.

In D45888#1047016, @jhb wrote:

I think "Universal version" may not age well. Maybe reference the modern LUA version you want to target that your earlier reverts are related to?

The problem is that it's not about the lua version, those are just things we've removed from the loader's specific liblua- we don't have any other version to tie it to.

I think bumping everyone to 3.0 is fine. I did wonder about just using the major version going forward (e.g. 15 in main), but that's probably overkill and too many gratuitous versions.

👍

Can we please make sure pxeboot is small enough (again) before doing that bump so that we know that was a usable version at least?

In D45888#1047562, @bz wrote:

Can we please make sure pxeboot is small enough (again) before doing that bump so that we know that was a usable version at least

This won't change that... last i checked we were good with the text only loader as the payload for sure and the full graphics loader looked to be small enough.

In D45888#1047563, @imp wrote:
In D45888#1047562, @bz wrote:

Can we please make sure pxeboot is small enough (again) before doing that bump so that we know that was a usable version at least

This won't change that... last i checked we were good with the text only loader as the payload for sure and the full graphics loader looked to be small enough.

I was just saying given whatever we currently install as pxeboot barfed on a Supermicro X10SRG-F (mercat) in the TestCluster a few days ago and I had to revert to an old version lying around somewhere again.

In D45888#1047564, @bz wrote:
In D45888#1047563, @imp wrote:
In D45888#1047562, @bz wrote:

Can we please make sure pxeboot is small enough (again) before doing that bump so that we know that was a usable version at least

This won't change that... last i checked we were good with the text only loader as the payload for sure and the full graphics loader looked to be small enough.

I was just saying given whatever we currently install as pxeboot barfed on a Supermicro X10SRG-F (mercat) in the TestCluster a few days ago and I had to revert to an old version lying around somewhere again.

Ah. This is orthogonal... at worst you’ll get a this boot loader needs to be updated message.. it's harmless...

The other issue may be worth pursuing elsewhere though

In D45888#1047565, @imp wrote:
In D45888#1047564, @bz wrote:
In D45888#1047563, @imp wrote:
In D45888#1047562, @bz wrote:

Can we please make sure pxeboot is small enough (again) before doing that bump so that we know that was a usable version at least

This won't change that... last i checked we were good with the text only loader as the payload for sure and the full graphics loader looked to be small enough.

I was just saying given whatever we currently install as pxeboot barfed on a Supermicro X10SRG-F (mercat) in the TestCluster a few days ago and I had to revert to an old version lying around somewhere again.

Ah. This is orthogonal... at worst you’ll get a this boot loader needs to be updated message.. it's harmless...

The other issue may be worth pursuing elsewhere though

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257018 and related reviews you commented on; I think all I am saying is -- it would be sad if not all "loaders" would work when we do a major version bump.

update version description, thought it doesn't really matter that much. jhb
didn't like Universal, so I was more specific.

This revision is now accepted and ready to land.Jul 29 2024, 10:35 PM
In D45888#1047568, @bz wrote:
In D45888#1047565, @imp wrote:
In D45888#1047564, @bz wrote:
In D45888#1047563, @imp wrote:
In D45888#1047562, @bz wrote:

Can we please make sure pxeboot is small enough (again) before doing that bump so that we know that was a usable version at least

This won't change that... last i checked we were good with the text only loader as the payload for sure and the full graphics loader looked to be small enough.

I was just saying given whatever we currently install as pxeboot barfed on a Supermicro X10SRG-F (mercat) in the TestCluster a few days ago and I had to revert to an old version lying around somewhere again.

Ah. This is orthogonal... at worst you’ll get a this boot loader needs to be updated message.. it's harmless...

The other issue may be worth pursuing elsewhere though

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257018 and related reviews you commented on; I think all I am saying is -- it would be sad if not all "loaders" would work when we do a major version bump.

All loaders require a major bump. But it's just a number. At worst, if you have an "old" loader, it will complain that you might not have a new enough loader and you should update (which you should). But if you don't, things will work until we remove the backwards compat shims this patch train adds back.

pxe is a separate issue, and one I claim is fixed now that I slimmed down the default boot loader a bit to make it not too close to the limit...

This revision was automatically updated to reflect the committed changes.