Paths

Table of Contentst

Differential D45889

stand: Print a warning of the loader is too old
ClosedPublic
Actions

Authored by imp on Jul 5 2024, 8:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 4:49 AM

	Unknown Object (File)
	Thu, Nov 7, 8:47 PM

	Unknown Object (File)
	Wed, Nov 6, 8:42 PM

	Unknown Object (File)
	Oct 17 2024, 7:00 AM

	Unknown Object (File)
	Oct 16 2024, 8:23 PM

	Unknown Object (File)
	Oct 14 2024, 8:31 PM

	Unknown Object (File)
	Oct 14 2024, 12:06 AM

	Unknown Object (File)
	Oct 11 2024, 2:49 PM

View All 47 Files

Subscribers

Details

Reviewers

kevans
manu

Commits

rG6b0a2b19c845: stand: Print a warning of the loader is too old
rG53a4bf76c57b: stand: Print a warning of the loader is too old
rGa2fd7ae87991: stand: Print a warning of the loader is too old

Summary

If the loader is < 3.0, print a warning that it's too old and needs to
be upgraded.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 5 2024, 8:48 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 5 2024, 8:48 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Jul 5 2024, 8:48 PM

Harbormaster completed remote builds in B58527: Diff 140600.Jul 5 2024, 8:48 PM

imp added a parent revision: D45888: loader: Bump all versions to 3.0.Jul 5 2024, 8:48 PM

imp added a child revision: D45890: stand: Add "Loader needs updating" to the first menu item".

jhb added a subscriber: jhb.Jul 9 2024, 2:02 PM

jhb added inline comments.

stand/lua/core.lua
549	Not sure why `loader_major` exists otherwise? Do you want to maybe call it `loader_min_major`?

kevans accepted this revision.Jul 9 2024, 8:43 PM

This revision is now accepted and ready to land.Jul 9 2024, 8:43 PM

imp added inline comments.Jul 29 2024, 10:40 PM

stand/lua/core.lua
549	yes. the above '3' should be spelled loader_major, like you suggest. I'll fix that.

Closed by commit rGa2fd7ae87991: stand: Print a warning of the loader is too old (authored by imp). · Explain WhyJul 29 2024, 10:58 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGa2fd7ae87991: stand: Print a warning of the loader is too old.

imp added a commit: rG53a4bf76c57b: stand: Print a warning of the loader is too old.Aug 1 2024, 2:52 PM

imp added a commit: rG6b0a2b19c845: stand: Print a warning of the loader is too old.Aug 1 2024, 2:57 PM

I really like this change. The latest vm snapshots are triggering the upgrade message, but there are no google results for how to upgrade. Can you point me to the correct way to upgrade and I'll draft a change for the handbook with the upgrade message included.

Revision Contents
Changeset List

Path

Size

stand/

lua/

21 lines

4 lines

Diff 141554

stand/lua/core.lua

Loading...

stand/lua/core.lua.8

Loading...