net: Remove unneeded NULL check for the allocated ifnet

[zlei]

Summary

Change 4787572d0580 made if_alloc_domain() never fail, then also does the
wrappers if_alloc(), if_alloc_dev() and if_gethandle().

No functional change intended.

MFC after: ???

[zlei]

The full diff is quite large ( about 7 megabytes ). See my dev branch https://github.com/gmshake/freebsd-src/tree/main_if_alloc instead, or I can upload the full diff if requested.

sys/dev/bxe/bxe.c

12988

if_gethandle() was introduced in change 62d76917b867 . In FreeBSD net stack it is just a thin wrapper around if_alloc(). Since 4787572d0580 is a behavior change, I doubt the net stack of Juniper Networks will follow.

Can @glebius comment on that ?

[glebius]

In D45740#1043263, @zlei wrote:

The full diff is quite large ( about 7 megabytes ). See my dev branch https://github.com/gmshake/freebsd-src/tree/main_if_alloc instead, or I can upload the full diff if requested.

I'm not from Juniper :) I would guess Juniper is fine with the proposed changes. They care about IfAPI hiding 'struct ifnet' better and better as time goes by, they don't have a requirement for the API to be never ever changing. I'll add Stephen to reviewers to correct me.

[imp]

Looks good. I can't answer the wrapper question definitively, but I suspect it will be fine.

[stevek]

In D45740#1043372, @glebius wrote:

In D45740#1043263, @zlei wrote:

The full diff is quite large ( about 7 megabytes ). See my dev branch https://github.com/gmshake/freebsd-src/tree/main_if_alloc instead, or I can upload the full diff if requested.

I'm not from Juniper :) I would guess Juniper is fine with the proposed changes. They care about IfAPI hiding 'struct ifnet' better and better as time goes by, they don't have a requirement for the API to be never ever changing. I'll add Stephen to reviewers to correct me.

Yes, this change is fine.

[zlei]

Landed as aa3860851b9f but it seems Phabricator got fooled.