Page MenuHomeFreeBSD

swap_pager: small improvement to find_least
ClosedPublic

Authored by dougm on Jun 11 2024, 7:38 AM.
Tags
None
Referenced Files
F101990301: D45558.diff
Wed, Nov 6, 6:29 AM
Unknown Object (File)
Mon, Oct 28, 2:55 PM
Unknown Object (File)
Sep 21 2024, 12:06 AM
Unknown Object (File)
Sep 18 2024, 6:15 AM
Unknown Object (File)
Sep 16 2024, 1:53 AM
Unknown Object (File)
Aug 31 2024, 10:33 PM
Unknown Object (File)
Aug 31 2024, 2:48 PM
Unknown Object (File)
Aug 31 2024, 2:48 PM
Subscribers

Details

Summary

This change drops an unneeded test, a branch and avoids a needless computation. Altogether, it saves 10 bytes of instructions on amd64.

It will mean that, on the path to MPASS(0), the same lookup and iteration will happen twice.

Test Plan

The kernel still boots.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 11 2024, 7:38 AM
dougm created this revision.
kib added inline comments.
sys/vm/swap_pager.c
2279
2312

Perhaps it is the time to change these two lines into __unreachable().

This revision is now accepted and ready to land.Jun 11 2024, 2:39 PM
This revision was automatically updated to reflect the committed changes.