vmm: Only link the arm64 hyp code in vmm.ko once
ClosedPublic
Actions

Authored by andrew on Jun 3 2024, 4:21 PM.

Details

Reviewers

kib
markj
imp

Group Reviewers

arm64

Commits

rG63f7a383434a: vmm: Only link the arm64 hyp code in vmm.ko once

Summary

This code runs at EL2 while the kernel runs at EL1. We build these
files for EL2 through a dependency in vmm_hyp_blob.elf.full so there
is no need to include them in SRCS.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jun 3 2024, 4:21 PM

Herald added subscribers: rgrimes, imp. · View Herald TranscriptJun 3 2024, 4:21 PM

andrew requested review of this revision.Jun 3 2024, 4:21 PM

Harbormaster completed remote builds in B58023: Diff 139363.Jun 3 2024, 4:21 PM

andrew added a parent revision: D45466: arm64: Support BTI checking in most of the kernel.Jun 3 2024, 4:21 PM

andrew added a child revision: D45468: linux64: Fix the build on arm64 with bti checking.

imp accepted this revision.Jun 3 2024, 6:06 PM

imp added inline comments.

sys/modules/vmm/Makefile
36–37	Would this warrant a comment that's a shortened version of the commit message? Either way I'm cool, but I kinda think it does, not least because CFLAGS and CLEAN have the same number of letters and at first glance these look the same.