Page MenuHomeFreeBSD
Differential D45264

arm64/rockchip: Fix the build with GCC
ClosedPublic
Actions

Authored by andrew on May 20 2024, 12:00 PM.
Tags
None
Referenced Files
F97482718: D45264.id138894.diff
Sun, Sep 29, 3:26 PM
F97482715: D45264.id138765.diff
Sun, Sep 29, 3:26 PM
F97452052: D45264.diff
Sun, Sep 29, 10:40 AM
Unknown Object (File)
Wed, Sep 18, 6:36 AM
Unknown Object (File)
Tue, Sep 17, 10:55 PM
Unknown Object (File)
Mon, Sep 16, 8:18 PM
Unknown Object (File)
Sun, Sep 15, 10:14 PM
Unknown Object (File)
Wed, Sep 4, 6:34 AM
View All 25 Files
Subscribers
loos

Details

Reviewers
brooks
imp
emaste
jhb
manu
Group Reviewers
arm64
Commits
rG0fdc0f361482: arm64/rockchip: Fix the build with GCC
rG29f8816b668b: arm64/rockchip: Fix the build with GCC
rG4f012d7a7a47: arm64/rockchip: Fix the build with GCC
Summary

We were missing brackets in GPIO_FLAGS_PINCTRL. Without them GCC
complains a use is ambiguous. Fix by adding the needed brackets.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.May 20 2024, 12:00 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 20 2024, 12:00 PM
Herald added a subscriber: loos. · View Herald Transcript
andrew requested review of this revision.May 20 2024, 12:00 PM
andrew added a parent revision: D45263: arm64: Use the pointer auth register defines.
andrew added a child revision: D45265: pci: Fix pci_host_generic_acpi with gcc.
Harbormaster completed remote builds in B57778: Diff 138765.May 20 2024, 12:01 PM
manu accepted this revision.May 20 2024, 4:19 PM
This revision is now accepted and ready to land.May 20 2024, 4:19 PM
jhb accepted this revision.May 20 2024, 5:29 PM
emaste accepted this revision.May 20 2024, 5:34 PM
brooks accepted this revision.May 20 2024, 6:22 PM
imp accepted this revision.May 20 2024, 10:58 PM
Closed by commit rG4f012d7a7a47: arm64/rockchip: Fix the build with GCC (authored by andrew). · Explain WhyMay 22 2024, 8:34 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG4f012d7a7a47: arm64/rockchip: Fix the build with GCC.
andrew added a commit: rG29f8816b668b: arm64/rockchip: Fix the build with GCC.Jul 15 2024, 12:39 PM
andrew added a commit: rG0fdc0f361482: arm64/rockchip: Fix the build with GCC.

Revision Contents
Changeset List

PathSize
sys/
arm64/
rockchip/
2 lines

Diff 138894

View Options

sys/arm64/rockchip/rk_gpio.c

Loading...