Page MenuHomeFreeBSD

libgcc_s: Add a linker script to link to libgcc
AcceptedPublic

Authored by andrew on May 20 2024, 12:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 29 2024, 10:41 AM
Unknown Object (File)
Sep 20 2024, 6:11 PM
Unknown Object (File)
Sep 17 2024, 2:07 PM
Unknown Object (File)
Sep 3 2024, 8:07 AM
Unknown Object (File)
Aug 14 2024, 8:13 AM
Unknown Object (File)
Jul 31 2024, 9:11 PM
Unknown Object (File)
Jul 29 2024, 7:27 AM
Unknown Object (File)
Jun 29 2024, 9:41 PM
Subscribers
None

Details

Reviewers
brooks
imp
emaste
jhb
jrtc27
Group Reviewers
arm64
Summary

When using outline atomics on arm64 the compiler will create a call to
a function that performs the atomic operation. This allows us to use
the fastest operation depending on the hardware.

As these functions are implemented in libgcc create a linker script
so libraries that link against libgcc_s will include libgcc to pull
them in.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57782
Build 54670: arc lint + arc unit

Event Timeline

andrew created this revision.
This revision is now accepted and ready to land.May 20 2024, 1:12 PM

I wonder if this would be useful on risc64 which has similar issues. There I have been trying (but not succeeding) to get GCC's libatomic.a to build and install as part of the freebsdN-gcc ports so that it could be linked to.

This seems to match what GCC does, though I'm not sure why either need it. Both drivers pass both of -lgcc and -lgcc_s, whether building an executable or shared library (well, testing with GCC 13.2 on arm64 Linux, as that's easily to hand). Can you elaborate on the exact issue you're seeing without this?

In D45268#1032769, @jhb wrote:

I wonder if this would be useful on risc64 which has similar issues. There I have been trying (but not succeeding) to get GCC's libatomic.a to build and install as part of the freebsdN-gcc ports so that it could be linked to.

GCC 13+ should inline subword atomics like LLVM on RISC-V. Don't bother working around the old stupid mess; even the Linux distros gave up on that one.

Without this some of the Google tests failed to link as the __aarch64_* atomic functions from lse.S are missing. These are in libgcc but not libgcc_s.

The errors I get from the linker without this change are similar to the following.

/usr/local/bin/aarch64-unknown-freebsd14.0-ld: gmock-actions_test: hidden symbol `__aarch64_ldadd8_acq_rel' in /usr/obj/home/andtur04/freebsd/repo/freebsd-gcc/arm64.aarch64/tmp/usr/lib/libgcc.a(outline_atomic_ldadd8_4.o) is referenced by DSO 
/usr/local/bin/aarch64-unknown-freebsd14.0-ld: final link failed: bad value
collect2: error: ld returned 1 exit status

As discussed on IRC it looks like in some cases gcc passes -lgcc and -lgcc_s when run as cc, but -lgcc_s -lgcc_s when run as c++