Page MenuHomeFreeBSD
Differential D44877

libgcc_s: restore __*_frame_info symbols post llvm18
ClosedPublic
Actions

Authored by brooks on Apr 19 2024, 9:28 PM.
Tags
None
Referenced Files
F106317757: D44877.diff
Sat, Dec 28, 2:50 PM
Unknown Object (File)
Thu, Dec 26, 8:05 PM
Unknown Object (File)
Nov 24 2024, 12:01 AM
Unknown Object (File)
Nov 20 2024, 5:31 PM
Unknown Object (File)
Nov 20 2024, 3:29 PM
Unknown Object (File)
Nov 13 2024, 11:27 PM
Unknown Object (File)
Nov 12 2024, 9:45 AM
Unknown Object (File)
Nov 7 2024, 5:01 PM
View All 60 Files
Subscribers
imp

Details

Reviewers
dim
Commits
rG82d22a88c340: libgcc_{eh,s}: restore __*_frame_info symbols post llvm18
rGa4f6bfe30406: libgcc_{eh,s}: restore __*_frame_info symbols post llvm18
rG0b9e3585805e: libgcc_{eh,s}: restore __*_frame_info symbols post llvm18
Summary

The upstream llvm commit 5eb44df1b64d made the addition of these GCC
compatability symbols dependent on build configuration rather than
hardcoded for amd64, i386, and powerpc. Reenable them.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Apr 19 2024, 9:28 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 19 2024, 9:28 PM
brooks requested review of this revision.Apr 19 2024, 9:28 PM
Harbormaster completed remote builds in B57235: Diff 137418.Apr 19 2024, 9:28 PM
brooks added a child revision: D44216: Make WITHOUT_UNDEFINED_VERSION the default.Apr 19 2024, 9:31 PM
dim accepted this revision.Apr 19 2024, 9:35 PM

Otherwise, LGTM.

lib/libgcc_eh/Makefile.inc
20

I'm always a bit confused by these unquoted strings... But apparently make groks this? :)

This revision is now accepted and ready to land.Apr 19 2024, 9:35 PM
dim added a comment.Apr 19 2024, 9:36 PM

Also, should we MFC this?

brooks added inline comments.Apr 19 2024, 9:42 PM
lib/libgcc_eh/Makefile.inc
20

I can quote them if you prefer

dim added inline comments.Apr 19 2024, 9:48 PM
lib/libgcc_eh/Makefile.inc
20

I can quote them if you prefer

Please do, other string values are also quoted in this same file.

Closed by commit rG0b9e3585805e: libgcc_{eh,s}: restore __*_frame_info symbols post llvm18 (authored by brooks). · Explain WhyApr 19 2024, 9:56 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG0b9e3585805e: libgcc_{eh,s}: restore __*_frame_info symbols post llvm18.
dim added a commit: rGa4f6bfe30406: libgcc_{eh,s}: restore __*_frame_info symbols post llvm18.Apr 20 2024, 10:33 AM
dim added a commit: rG82d22a88c340: libgcc_{eh,s}: restore __*_frame_info symbols post llvm18.

Revision Contents
Changeset List

PathSize
lib/
libgcc_eh/
3 lines

Diff 137421

View Options

lib/libgcc_eh/Makefile.inc

Loading...