ctl_backend_ramdisk: Add support for NVMe
ClosedPublic
Actions

Authored by jhb on Apr 9 2024, 11:04 PM.

Details

Reviewers

imp
ken

Group Reviewers

cam

Commits

rGd5c21c68833d: ctl_backend_ramdisk: Add support for NVMe

Summary

One known caveat is that the support for WRITE_UNCORRECTABLE is not
quite correct as reads from LBAs after a WRITE_UNCORRECTABLE will
return zeroes rather than an error. Fixing this would likely require
special handling for PG_ANCHOR for NVMe requests (or adding a new
PG_UNCORRECTABLE).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57194
Build 54082: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 9 2024, 11:04 PM

Herald added a reviewer: cam. · View Herald TranscriptApr 9 2024, 11:04 PM

jhb requested review of this revision.Apr 9 2024, 11:04 PM

Harbormaster completed remote builds in B57013: Diff 136818.Apr 9 2024, 11:04 PM

jhb added a parent revision: D44721: ctl: Add helper routines to populate NVMe namespace data IDs for a LUN.Apr 9 2024, 11:04 PM

jhb added a child revision: D44723: ctl_backend_block: Add support for NVMe.

jhb added a reviewer: ken.Apr 9 2024, 11:11 PM

ken accepted this revision.Apr 15 2024, 3:20 PM

This revision is now accepted and ready to land.Apr 15 2024, 3:20 PM

I think the write uncorrectable is fine as it is, at least for now. It's not used by FreeBSD, but likely by others so it will eventually need to be supported. It need not gate this, though.

jhb retitled this revision from ctl_backend_ramdisk: Add support for NVMe support to ctl_backend_ramdisk: Add support for NVMe.Apr 18 2024, 5:52 PM

jhb added a parent revision: D44849: ctl_backend_ramdisk: Prepare for NVMe support.

jhb removed a parent revision: D44721: ctl: Add helper routines to populate NVMe namespace data IDs for a LUN.

Update after splitting into 2 commits

This revision now requires review to proceed.Apr 18 2024, 5:57 PM

Harbormaster completed remote builds in B57194: Diff 137333.Apr 18 2024, 5:57 PM

jhb edited child revisions, added: D44851: ctl_backend_block: Prepare for NVMe support; removed: D44723: ctl_backend_block: Add support for NVMe.Apr 18 2024, 5:58 PM

Update for CTL_IO_ASSERT macro

Harbormaster completed remote builds in B57508: Diff 137972.May 1 2024, 8:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2024, 12:16 AM

Closed by commit rGd5c21c68833d: ctl_backend_ramdisk: Add support for NVMe (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.