Page MenuHomeFreeBSD
Differential D44703

nvmf_proto.h: NVMe over Fabrics protocol definitions
ClosedPublic
Actions

Authored by jhb on Apr 9 2024, 11:03 PM.
Tags
None
Referenced Files
F102837802: D44703.diff
Sun, Nov 17, 7:53 PM
Unknown Object (File)
Wed, Nov 6, 10:19 AM
Unknown Object (File)
Sat, Nov 2, 9:02 PM
Unknown Object (File)
Fri, Nov 1, 4:38 AM
Unknown Object (File)
Wed, Oct 30, 10:20 AM
Unknown Object (File)
Mon, Oct 21, 1:40 PM
Unknown Object (File)
Sep 30 2024, 3:35 AM
Unknown Object (File)
Sep 29 2024, 10:03 PM
View All 33 Files
Subscribers
None

Details

Reviewers
imp
Commits
rGf2e737683eef: nvmf_proto.h: NVMe over Fabrics protocol definitions
Summary

This is a copy of spdk/include/spdk/nvmf_spec.h as of commit
470e851852bb948334a272c9f8de495020fa082f from Intel's SPDK.
Subsequent commits will modify it to be suitable header for the
kernel, but importing the stock file first makes it easier to see
how the resulting header is derived from the original.

Obtained from: SPDK (https://github.com/spdk/spdk.git)
Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 9 2024, 11:03 PM
jhb created this revision.
Harbormaster completed remote builds in B56994: Diff 136799.Apr 9 2024, 11:03 PM
jhb added a child revision: D44704: nvmf_proto.h: Update for use in FreeBSD.Apr 9 2024, 11:03 PM
jhb added a comment.Apr 9 2024, 11:05 PM

I don't foresee pulling in future updates from SPDK so don't think this should belong in contrib from a vendor branch, etc. However, seeing the stock file first is helpful I think.

imp accepted this revision.Apr 15 2024, 4:24 PM

minor nits and a question.

sys/dev/nvmf/nvmf_proto.h
2

Putting the SPDX on a new line would be more in keeping with our style.

20

This is a mismatch with the tree. Is that this is how SPDK managed this?

722

Doesn't match top of file.

This revision is now accepted and ready to land.Apr 15 2024, 4:24 PM
jhb added a comment.Apr 16 2024, 5:44 PM

To be clear, this is the stock file from SPDK without any changes.

Closed by commit rGf2e737683eef: nvmf_proto.h: NVMe over Fabrics protocol definitions (authored by jhb). · Explain WhyMay 3 2024, 12:15 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGf2e737683eef: nvmf_proto.h: NVMe over Fabrics protocol definitions.

Revision Contents
Changeset List

PathSize
sys/
dev/
nvmf/
721 lines

Diff 138052

View Options

sys/dev/nvmf/nvmf_proto.h

Loading...