Paths

Table of Contentst

Differential D44269

newbus: Remove redundant check for 0
ClosedPublic
Actions

Authored by imp on Mar 7 2024, 7:15 PM.

Tags

None

Referenced Files

	F102002596: D44269.diff
	Wed, Nov 6, 10:22 AM

	Unknown Object (File)
	Sun, Oct 20, 9:39 PM

	Unknown Object (File)
	Sun, Oct 20, 9:39 PM

	Unknown Object (File)
	Sun, Oct 20, 9:38 PM

	Unknown Object (File)
	Sun, Oct 20, 9:38 PM

	Unknown Object (File)
	Sun, Oct 20, 9:09 PM

	Unknown Object (File)
	Wed, Oct 16, 3:19 AM

	Unknown Object (File)
	Wed, Oct 9, 1:03 AM

View All 28 Files

Subscribers

Details

Reviewers

jhb
jrtc27

Commits

rG42b7e9c4a9c5: newbus: Remove redundant check for 0

Summary

We already checked to see if the return code is 0 above. This code is
redundant.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56500
Build 53388: arc lint + arc unit

Event Timeline

imp created this revision.Mar 7 2024, 7:15 PM

Herald added a subscriber: olce. · View Herald TranscriptMar 7 2024, 7:15 PM

imp requested review of this revision.Mar 7 2024, 7:15 PM

Harbormaster completed remote builds in B56500: Diff 135511.Mar 7 2024, 7:15 PM

imp added a child revision: D44264: newbus: Create %probe_bias in every devclass.Mar 7 2024, 7:15 PM

actually fix the redundancy

Harbormaster completed remote builds in B56502: Diff 135515.Mar 7 2024, 7:27 PM

imp added inline comments.Mar 7 2024, 7:30 PM

sys/kern/subr_bus.c
1670	I suppose this line could also be dropped.
1753	Maybe we finally need to implement strdup above.

jhb accepted this revision.Mar 13 2024, 8:40 PM

jhb added inline comments.

sys/kern/subr_bus.c
1670	Yes, you can drop `pri == 0`
1671	`out` is ok, but you could also use something like `exact_match` or some other name for the label.
1753	Lots of description strings are constants rather than dynamically allocated. I don't think it would matter if we started always dynamically allocating them though.

This revision is now accepted and ready to land.Mar 13 2024, 8:40 PM

Closed by commit rG42b7e9c4a9c5: newbus: Remove redundant check for 0 (authored by imp). · Explain WhyWed, Oct 16, 3:19 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG42b7e9c4a9c5: newbus: Remove redundant check for 0.

Revision Contents
Changeset List

Path

Size

sys/

kern/

6 lines

Diff 135511

sys/kern/subr_bus.c

Loading...