Page MenuHomeFreeBSD

openssl: don't export nonexistant symbols
ClosedPublic

Authored by brooks on Mar 5 2024, 10:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 20 2024, 1:37 AM
Unknown Object (File)
Nov 14 2024, 2:00 PM
Unknown Object (File)
Nov 12 2024, 9:23 AM
Unknown Object (File)
Nov 5 2024, 9:13 AM
Unknown Object (File)
Nov 4 2024, 11:14 AM
Unknown Object (File)
Nov 4 2024, 11:05 AM
Unknown Object (File)
Nov 4 2024, 11:05 AM
Unknown Object (File)
Nov 4 2024, 10:58 AM
Subscribers

Details

Summary

These are all OpenSSL 1.1.0 and 1.1.1 symbols that aren't present in our
OpenSSL 3.0 builds.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56472
Build 53360: arc lint + arc unit

Event Timeline

secure/lib/libssl/Version.map
390–392

these are in crypto/openssl/ssl/methods.c, in # ifndef OPENSSL_NO_SSL3_METHOD which gets set in crypto/openssl/include/openssl/configuration.h

# ifndef OPENSSL_NO_SSL3_METHOD
#  define OPENSSL_NO_SSL3_METHOD
# endif
secure/lib/libssl/Version.map
390–392

Ok, so they aren't built and there's no way to enable them short of editing crypto/openssl/include/openssl/configuration.h.

emaste added inline comments.
secure/lib/libssl/Version.map
390–392

Yep - sorry I didn't add more in that comment. I added the comment because I at first thought they were (at least) optional but discovered that in the configuration in the tree they are indeed disabled and should not be in the symbol file.

This revision is now accepted and ready to land.Apr 22 2024, 3:55 PM
This revision was automatically updated to reflect the committed changes.