gicv3: In its_init_cpu_lpi record each cpu's PENDBASER
ClosedPublic
Actions

Authored by imp on Feb 23 2024, 4:47 AM.

Details

Reviewers

andrew
manu

Commits

rGb53202779c2e: gicv3: In its_init_cpu_lpi record each cpu's PENDBASER
rG1d13cc200820: gicv3: In its_init_cpu_lpi record each cpu's PENDBASER

Summary

When we're using the preallocated memory for gicv3, record each cpu's
PEND_BASER where we'd normally allocate memory for it. Make sure that
memory is in the excluded list and map the PA to VA and store that,
to mimic what we do with the allocation case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Feb 23 2024, 4:47 AM

Herald added a reviewer: andrew. · View Herald TranscriptFeb 23 2024, 4:47 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a subscriber: emaste. · View Herald Transcript

imp requested review of this revision.Feb 23 2024, 4:47 AM

imp added a parent revision: D44036: gicv3: Report PENDBASE when bootverbose.

Harbormaster completed remote builds in B56182: Diff 134871.Feb 23 2024, 4:47 AM

imp added a child revision: D44038: gicv3: If the LPI is already allocated, remember it.Feb 23 2024, 4:47 AM

Better panic message
Fix GICV3_ITS_MASK usage and definition

Harbormaster completed remote builds in B56199: Diff 134909.Feb 23 2024, 11:44 PM

With the latest update, this now boots on the same hardware my hacky version that I abandoned did.

andrew added inline comments.Feb 27 2024, 10:12 AM

sys/arm64/arm64/gicv3_its.c
297	The `GICR_PENDBASER` table is 64k aligned. Bits 15:12 are reserved zero.
844	We should add `GICR_PENDBASER_PA_MASK` or similar to `gic_v3_reg.h` & use that to extract the physical address.
849	It looks like this adds spaces before the brace.

imp retitled this revision from gicv3: In its_init_cpu_lpi record each cpu's pend_base to gicv3: In its_init_cpu_lpi record each cpu's PENDBASER.Feb 27 2024, 4:27 PM

imp marked 3 inline comments as done.Feb 27 2024, 4:29 PM

imp added inline comments.

sys/arm64/arm64/gicv3_its.c
297	Indeed. https://reviews.freebsd.org/D44096 for the PA_MASKS I created. Thanks for catching that they were different (though in practice due to the stricter alignment, it all worked out -- yikes)
844	Done, I also defined GICR_PROPBASER_PA_MASK as well.
849	doh! Fixed.