Page MenuHomeFreeBSD
Differential D43830

reboot: Allow this to be installed as nextboot
ClosedPublic
Actions

Authored by imp on Feb 11 2024, 2:27 AM.
Tags
None
Referenced Files
F102672156: D43830.diff
Fri, Nov 15, 4:11 PM
Unknown Object (File)
Tue, Nov 12, 10:44 PM
Unknown Object (File)
Mon, Oct 21, 1:24 AM
Unknown Object (File)
Mon, Oct 21, 1:24 AM
Unknown Object (File)
Mon, Oct 21, 1:24 AM
Unknown Object (File)
Mon, Oct 21, 1:24 AM
Unknown Object (File)
Mon, Oct 21, 1:24 AM
Unknown Object (File)
Mon, Oct 21, 1:24 AM
View All 85 Files
Subscribers
cy

Details

Reviewers
kevans
emaste
kib
Commits
rG994cc8392123: reboot: Allow this to be installed as nextboot
Summary

Allow nextboot to be a symlink link to reboot. It does everything reboot
does, except doesn't actually setup the sytem to reboot and reboot. Also,
don't accept the reboot args related to rebooting when in nextboot mode.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55928
Build 52817: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 11 2024, 2:27 AM
imp created this revision.
Herald added a subscriber: cy. · View Herald TranscriptFeb 11 2024, 2:27 AM
Harbormaster completed remote builds in B55928: Diff 134129.Feb 11 2024, 2:27 AM
imp added a parent revision: D43829: reboot: Implement -o to set kernel options for next boot.Feb 11 2024, 2:27 AM
imp added a child revision: D43831: rescue,nextboot: Install nextboot as a link to reboot, rm nextboot.sh.
imp added reviewers: kevans, emaste, kib.Feb 11 2024, 2:31 AM
imp updated this revision to Diff 134150.Feb 11 2024, 5:06 PM

review comments

Harbormaster completed remote builds in B55940: Diff 134150.Feb 11 2024, 5:06 PM
kib accepted this revision.Feb 12 2024, 2:15 AM
kib added inline comments.
sbin/reboot/reboot.c
334
This revision is now accepted and ready to land.Feb 12 2024, 2:15 AM
emaste added inline comments.Feb 12 2024, 1:58 PM
sbin/reboot/reboot.c
201

Instead of having to repeat this many times, what about having a per-prog getopt string?

303
imp added inline comments.Feb 12 2024, 3:31 PM
sbin/reboot/reboot.c
303

Pre-existing style though, which i try not to gratuitously not change...

imp updated this revision to Diff 134202.Feb 12 2024, 6:33 PM

fold in ed's suggestion and add {} around the while loop to reflect updated
practices since this code was written.

This revision now requires review to proceed.Feb 12 2024, 6:33 PM
Harbormaster completed remote builds in B55963: Diff 134202.Feb 12 2024, 6:33 PM
imp updated this revision to Diff 134203.Feb 12 2024, 6:35 PM

oops, missed one

Harbormaster completed remote builds in B55964: Diff 134203.Feb 12 2024, 6:35 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2024, 6:54 PM
Closed by commit rG994cc8392123: reboot: Allow this to be installed as nextboot (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG994cc8392123: reboot: Allow this to be installed as nextboot.

Revision Contents
Changeset List

PathSize
sbin/
reboot/
27 lines

Diff 134129

View Options

sbin/reboot/reboot.c

Loading...