Page MenuHomeFreeBSD

arm: Set NEW_PCIB in DEFAULTS rather than a subset of kernel configs
ClosedPublic

Authored by jrtc27 on Feb 9 2024, 7:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 1:23 PM
Unknown Object (File)
Sep 28 2024, 6:29 AM
Unknown Object (File)
Sep 19 2024, 2:56 PM
Unknown Object (File)
Sep 18 2024, 4:31 PM
Unknown Object (File)
Sep 18 2024, 6:49 AM
Unknown Object (File)
Sep 16 2024, 11:40 AM
Unknown Object (File)
Sep 16 2024, 1:00 AM
Unknown Object (File)
Sep 14 2024, 2:05 AM
Subscribers
None

Details

Summary

All other architectures set NEW_PCIB in DEFAULTS, with arm being the one
remaining straggler that only sets it for GENERIC and TEGRA124.
ARMADA38X and ARMADAXP contain device pci but don't set NEW_PCIB,
however GENERIC claims to support them and as part of that NEW_PCIB
support was added to mv_pci, so these configs are most likely just
stale. Other than NOTES that just leaves ALPINE as the one kernel with
PCI support not covered by GENERIC, but al_pci is supported by arm64
which enables NEW_PCIB, and it's just a generic_pcie_fdt_driver with
some fixup code to deal with quirks so should support PCI_RES_BUS just
fine. Therefore it is believed that all in-tree kernel configs support
NEW_PCIB in reality, and so let's take a step towards removing all the
non-NEW_PCIB code by having it always-on everywhere.

MFC after: 1 month


Split out from D32954 to isolate the part with a slight risk of regression as
discussed on IRC.

Test Plan

Passed tinderbox -DWITHOUT_WORLDS -DMAKE_ALL_KERNELS

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55887
Build 52776: arc lint + arc unit

Event Timeline

jrtc27 requested review of this revision.Feb 9 2024, 7:31 PM

s/SYS_RES_BUS/PCI_RES_BUS/ in commit log

This revision is now accepted and ready to land.Feb 10 2024, 7:07 PM
In D43806#999575, @jhb wrote:

s/SYS_RES_BUS/PCI_RES_BUS/ in commit log

Oops; that's not the first time I've made that mistake, and most likely won't be the last...