Page MenuHomeFreeBSD

loader: Document the lua loader table.
ClosedPublic

Authored by imp on Feb 1 2024, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 6:15 PM
Unknown Object (File)
Sat, Oct 26, 3:50 PM
Unknown Object (File)
Sun, Oct 20, 5:18 PM
Unknown Object (File)
Sun, Oct 20, 5:16 PM
Unknown Object (File)
Sun, Oct 20, 5:15 PM
Unknown Object (File)
Sun, Oct 20, 5:15 PM
Unknown Object (File)
Sun, Oct 20, 5:14 PM
Unknown Object (File)
Sun, Oct 20, 5:14 PM

Details

Summary

Document all the public functions from the "loader" table.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 1 2024, 6:13 PM
sjg added inline comments.
stand/lua/loader.lua.8
14

built-in

imp marked an inline comment as done.Feb 1 2024, 6:37 PM
In D43701#996747, @imp wrote:

https://people.freebsd.org/~imp/loader.lua.8.html
has this with a decent rendering.

well, half decent. It's missing a few things, not sure if that's because I'd doing bad things, or because the conversions script just is ill suited for this project.

fix printc and add a note about loader.lua being the default file too.

stand/lua/loader.lua.8
26

"exported from in the" - either something is missing after "from" or what is meant is simply "exported from the" (or "exported by the"

142–143

"change callback function registers at creation" reads oddly to me. Perhaps "change callback function registered at creation"? But maybe there is some terminology in use here with which I'm unfamiliar.

235

Double period

pauamma_gundo.com added inline comments.
stand/lua/loader.lua.8
127
135–136

Audience check: What does "globally" mean here? Is it a concept that Lua users are likely familiar with?

155–157

Do you mean x2 and y2 for the last item?

174–181

I'd make that x0, y0, x1, y1 for consistency with other indexes.

192–199

Same as above.

imp marked 5 inline comments as done.

update to (hopefully) fix the review comments.

stand/lua/loader.lua.8
26

"exported from in the" - either something is missing after "from" or what is meant is simply "exported from the" (or "exported by the"

The following variables are provided by the Lua interpreter in the

135–136

Yes. They'll know about how Lua works.

142–143

I'll just drop it for now. It would be better to give a reference to something else, but the something else that I have is libstand.3, which is horribly out of date.

155–157

Yes.

174–181

I thought of that, but the code uses these odd function parameters. I don't know why. I wanted to make sure they matched in case there's some hidden meaning.

192–199

Same.

imp marked 2 inline comments as done.Feb 8 2024, 8:42 PM
This revision is now accepted and ready to land.Feb 8 2024, 9:00 PM

After checking with the author, I can make the args consistent.
Do so and add a note about units and origin.

This revision now requires review to proceed.Feb 9 2024, 9:18 PM
This revision is now accepted and ready to land.Feb 9 2024, 9:31 PM
This revision was automatically updated to reflect the committed changes.