Specifically for bus_activate/adjust/deactivate_bus methods.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 55405 Build 52294: arc lint + arc unit
Event Timeline
sys/dev/hyperv/pcib/vmbus_pcib.c | ||
---|---|---|
2011 | Please check the indentation here. |
sys/dev/hyperv/pcib/vmbus_pcib.c | ||
---|---|---|
2011 | The raw version looks fine. I think the previous version was not fully consistent. Here is the patched method table: /* Bus interface */ DEVMETHOD(bus_read_ivar, vmbus_pcib_read_ivar), DEVMETHOD(bus_write_ivar, vmbus_pcib_write_ivar), DEVMETHOD(bus_alloc_resource, vmbus_pcib_alloc_resource), DEVMETHOD(bus_adjust_resource, vmbus_pcib_adjust_resource), DEVMETHOD(bus_release_resource, vmbus_pcib_release_resource), DEVMETHOD(bus_activate_resource, vmbus_pcib_activate_resource), DEVMETHOD(bus_deactivate_resource, vmbus_pcib_deactivate_resource), DEVMETHOD(bus_setup_intr, bus_generic_setup_intr), DEVMETHOD(bus_teardown_intr, bus_generic_teardown_intr), DEVMETHOD(bus_get_cpus, vmbus_pcib_get_cpus), |
Comment Actions
Code looks fine to me, but has the new functions been tested on Azure ? As in local Hyper-V we mostly dont use pci passthrough.
Comment Actions
I do not have a means to test it, no. It is part of a larger API sweep/cleanup series.