Page MenuHomeFreeBSD

pci_host_generic: Use pci_domain_[de]activate_bus for PCI_RES_BUS resources
ClosedPublic

Authored by jhb on Jan 12 2024, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 17, 10:20 AM
Unknown Object (File)
Thu, Oct 17, 10:17 AM
Unknown Object (File)
Thu, Oct 17, 10:16 AM
Unknown Object (File)
Thu, Oct 17, 10:16 AM
Unknown Object (File)
Sep 22 2024, 2:19 PM
Unknown Object (File)
Sep 22 2024, 12:01 PM
Unknown Object (File)
Sep 22 2024, 9:35 AM
Unknown Object (File)
Sep 22 2024, 1:58 AM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jan 12 2024, 10:32 PM
jhb created this revision.
This revision is now accepted and ready to land.Jan 22 2024, 5:22 PM

I'll note in passing here that RES_BUS needing this many changes makes it not the greatest fit with resource management and if we ever do another one that requires this many special cases, we might want to think how it can be generalized. For now, though, the special cases I think are fine.

In D43429#992893, @imp wrote:

I'll note in passing here that RES_BUS needing this many changes makes it not the greatest fit with resource management and if we ever do another one that requires this many special cases, we might want to think how it can be generalized. For now, though, the special cases I think are fine.

I could perhaps define a pci_domain_rman that the various bus_get_rman methods could use. That would let more of the special cases fall out since bus_generic_rman_* could handle these.