Page MenuHomeFreeBSD

arm64: Enable SVE in userspace
AcceptedPublic

Authored by andrew on Jan 4 2024, 12:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 9, 3:56 AM
Unknown Object (File)
Fri, Sep 6, 3:34 AM
Unknown Object (File)
Wed, Sep 4, 11:04 AM
Unknown Object (File)
Sat, Aug 31, 7:02 PM
Unknown Object (File)
Wed, Aug 28, 3:29 PM
Unknown Object (File)
Aug 6 2024, 3:42 AM
Unknown Object (File)
Aug 5 2024, 1:52 PM
Unknown Object (File)
Aug 4 2024, 1:43 PM
Subscribers

Details

Reviewers
kib
markj
manu
Group Reviewers
arm64
Summary

Report when SVE is present and allow it to be used by calling
sve_restore_state on an SVE exception from userspace.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59119
Build 56006: arc lint + arc unit

Event Timeline

Do we need to add something to the AT_HWCAP2 vector as well? Or is that stuff all SVE2 only?

sys/arm64/arm64/identcpu.c
1386

This comment can go away now.

sys/arm64/arm64/trap.c
643

Almost all exception handlers do call userret(). If exceptions (pun is not intended) are intended (again not intended), then perhaps some explanation should be added in a form of comment.

Also, what about factoring out the userret call somewhere in a common place?

  • Remove an old comment
  • Call userret in the exception handler
  • Only tell userspace about SVE in FreeBSD userspace, Linux userspace support is missing needed syscalls
This revision is now accepted and ready to land.Sat, Aug 31, 11:53 PM