Page MenuHomeFreeBSD

pseudofs: fix off by one in hash iteration in pfs_purge
ClosedPublic

Authored by weike.chen_dell.com on Nov 16 2023, 8:25 AM.
Tags
None
Referenced Files
F116094726: D42628.diff
Fri, May 2, 12:02 PM
Unknown Object (File)
Sun, Apr 27, 8:15 AM
Unknown Object (File)
Wed, Apr 23, 4:03 PM
Unknown Object (File)
Sun, Apr 6, 12:47 PM
Unknown Object (File)
Feb 8 2025, 12:43 PM
Unknown Object (File)
Feb 8 2025, 11:29 AM
Unknown Object (File)
Jan 11 2025, 3:54 AM
Unknown Object (File)
Jan 11 2025, 12:53 AM
Subscribers

Details

Summary

Random KASSERT while rebooting, and it is due to pfs_purge doesn't clear the last hash entry as using the wrong hash size in hash table looping. 'pfs_vncache_hash + 1' is the really hash table size.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

The patch looks correct, but commit message needs some work.

I would say the following would be sufficient: "pseudofs: fix off by one in hash iteration in pfs_purge". I can plop this much myself.

However, what about 'sponsored by' or other tags?

In D42628#973358, @mjg wrote:

The patch looks correct, but commit message needs some work.

I would say the following would be sufficient: "pseudofs: fix off by one in hash iteration in pfs_purge". I can plop this much myself.

However, what about 'sponsored by' or other tags?

Please feel free to improve the commit message.
For Sponsor, I am working for Dell product, how about mark it to "sponsored by Dell Technologies "?

weike.chen_dell.com retitled this revision from KASSERT while pfs vncache unload. to pseudofs: fix off by one in hash iteration in pfs_purge.Nov 20 2023, 5:19 AM
weike.chen_dell.com edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Nov 20 2023, 5:58 AM
This revision was automatically updated to reflect the committed changes.