Page MenuHomeFreeBSD

pseudofs: fix off by one in hash iteration in pfs_purge
ClosedPublic

Authored by weike.chen_dell.com on Nov 16 2023, 8:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 4:54 PM
Unknown Object (File)
Thu, Oct 17, 1:31 AM
Unknown Object (File)
Thu, Oct 17, 1:30 AM
Unknown Object (File)
Thu, Oct 17, 1:30 AM
Unknown Object (File)
Thu, Oct 17, 1:12 AM
Unknown Object (File)
Oct 1 2024, 1:24 PM
Unknown Object (File)
Sep 30 2024, 11:24 AM
Unknown Object (File)
Sep 29 2024, 11:25 AM
Subscribers

Details

Summary

Random KASSERT while rebooting, and it is due to pfs_purge doesn't clear the last hash entry as using the wrong hash size in hash table looping. 'pfs_vncache_hash + 1' is the really hash table size.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The patch looks correct, but commit message needs some work.

I would say the following would be sufficient: "pseudofs: fix off by one in hash iteration in pfs_purge". I can plop this much myself.

However, what about 'sponsored by' or other tags?

In D42628#973358, @mjg wrote:

The patch looks correct, but commit message needs some work.

I would say the following would be sufficient: "pseudofs: fix off by one in hash iteration in pfs_purge". I can plop this much myself.

However, what about 'sponsored by' or other tags?

Please feel free to improve the commit message.
For Sponsor, I am working for Dell product, how about mark it to "sponsored by Dell Technologies "?

weike.chen_dell.com retitled this revision from KASSERT while pfs vncache unload. to pseudofs: fix off by one in hash iteration in pfs_purge.Nov 20 2023, 5:19 AM
weike.chen_dell.com edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Nov 20 2023, 5:58 AM
This revision was automatically updated to reflect the committed changes.