Page MenuHomeFreeBSD
Differential D42135

x86: Rename {stop,start}_emulating to fpu_{enable,disable}
ClosedPublic
Actions

Authored by jhb on Oct 9 2023, 4:27 PM.
Tags
None
Referenced Files
F96139381: D42135.id.diff
Mon, Sep 23, 8:01 PM
Unknown Object (File)
Sun, Sep 22, 1:53 AM
Unknown Object (File)
Fri, Sep 20, 1:03 AM
Unknown Object (File)
Wed, Sep 18, 11:12 AM
Unknown Object (File)
Wed, Sep 18, 8:18 AM
Unknown Object (File)
Wed, Sep 18, 6:46 AM
Unknown Object (File)
Tue, Sep 17, 2:04 PM
Unknown Object (File)
Tue, Sep 17, 7:07 AM
View All 34 Files
Subscribers
bcran
emaste
imp
rgrimes

Details

Reviewers
markj
kib
Group Reviewers
bhyve
Commits
rGf27c8ff817a6: x86: Rename {stop,start}_emulating to fpu_{enable,disable}
rGcc1cb9ea0c56: x86: Rename {stop,start}_emulating to fpu_{enable,disable}
Summary

While here, centralize the macros in <x86/fpu.h>.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Oct 9 2023, 4:27 PM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 9 2023, 4:27 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
jhb requested review of this revision.Oct 9 2023, 4:27 PM
jhb added a parent revision: D42134: amd64: Remove a stale comment from cpu_setregs.
Harbormaster completed remote builds in B53902: Diff 128458.Oct 9 2023, 4:27 PM
jhb added a child revision: D42136: x86: Add a new NT_X86_CPUID regset for ptrace and core dumps.Oct 9 2023, 4:27 PM
markj added inline comments.Oct 9 2023, 4:36 PM
sys/amd64/amd64/fpu.c
803

fpu_enable()?

jhb added inline comments.Oct 9 2023, 8:12 PM
sys/amd64/amd64/fpu.c
803

I chose clts() here due to the comment above explicitly referencing %cr0.TS, but perhaps fpu_enable() is more correct?

kib added inline comments.Oct 9 2023, 10:55 PM
sys/amd64/amd64/fpu.c
803

I do not think the specific name there matters. Perhaps the comment should stop referencing lazy mode.

Might be, it is time to remove the workaround as well (I am not too sure about it).

markj accepted this revision as: markj.Oct 11 2023, 1:38 PM
markj added inline comments.
sys/amd64/amd64/fpu.c
803

I slightly prefer to be consistent and write fpu_enable().

This revision is now accepted and ready to land.Oct 11 2023, 1:38 PM
Closed by commit rGcc1cb9ea0c56: x86: Rename {stop,start}_emulating to fpu_{enable,disable} (authored by jhb). · Explain WhyOct 11 2023, 9:32 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGcc1cb9ea0c56: x86: Rename {stop,start}_emulating to fpu_{enable,disable}.
jhb added a commit: rGf27c8ff817a6: x86: Rename {stop,start}_emulating to fpu_{enable,disable}.Dec 29 2023, 11:11 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
31 lines
vmm/
15 lines
i386/
i386/
35 lines
x86/
include/
9 lines

Diff 128618

View Options

sys/amd64/amd64/fpu.c

Loading...
View Options

sys/amd64/vmm/vmm.c

Loading...
View Options

sys/i386/i386/npx.c

Loading...
View Options

sys/x86/include/fpu.h

Loading...