Page MenuHomeFreeBSD

x86: Rename {stop,start}_emulating to fpu_{enable,disable}
ClosedPublic

Authored by jhb on Oct 9 2023, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2025, 2:19 PM
Unknown Object (File)
Feb 22 2025, 1:57 PM
Unknown Object (File)
Feb 22 2025, 1:36 PM
Unknown Object (File)
Feb 4 2025, 11:56 AM
Unknown Object (File)
Jan 25 2025, 6:54 AM
Unknown Object (File)
Jan 17 2025, 11:57 PM
Unknown Object (File)
Jan 17 2025, 3:46 PM
Unknown Object (File)
Jan 17 2025, 3:31 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/amd64/amd64/fpu.c
803

fpu_enable()?

sys/amd64/amd64/fpu.c
803

I chose clts() here due to the comment above explicitly referencing %cr0.TS, but perhaps fpu_enable() is more correct?

sys/amd64/amd64/fpu.c
803

I do not think the specific name there matters. Perhaps the comment should stop referencing lazy mode.

Might be, it is time to remove the workaround as well (I am not too sure about it).

markj added inline comments.
sys/amd64/amd64/fpu.c
803

I slightly prefer to be consistent and write fpu_enable().

This revision is now accepted and ready to land.Oct 11 2023, 1:38 PM