Page MenuHomeFreeBSD
Differential D41916

arm64: Fix errata workarounds that depend on smccc
ClosedPublic
Actions

Authored by andrew on Sep 19 2023, 2:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 3:44 PM
Unknown Object (File)
Wed, Nov 6, 3:44 PM
Unknown Object (File)
Wed, Nov 6, 3:40 PM
Unknown Object (File)
Wed, Nov 6, 3:35 PM
Unknown Object (File)
Tue, Nov 5, 3:13 AM
Unknown Object (File)
Oct 7 2024, 4:14 PM
Unknown Object (File)
Sep 29 2024, 3:12 AM
Unknown Object (File)
Sep 8 2024, 7:39 AM
View All 45 Files
Subscribers
imp
kib

Details

Reviewers
emaste
manu
Group Reviewers
arm64
Commits
rG485912e051bb: arm64: Fix errata workarounds that depend on smccc
rG906bcc44641d: arm64: Fix errata workarounds that depend on smccc
rG4df1447f2c76: arm64: Fix errata workarounds that depend on smccc
rGcaf7bc535622: arm64: Fix errata workarounds that depend on smccc
rGc643e82dba0b: arm64: Fix errata workarounds that depend on smccc
Summary

Some arm64 errata depend on calling into the firmware via the SMCCC
interface. This needs to happen after the psci driver has attached
as they share the interface.

Fix this by allowing the workarounds to mark when they depend on
device drivers attaching.

This is only an issue on CPU 0 as the workarounds are applied later
for the non-boot CPUs.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53654
Build 50545: arc lint + arc unit

Event Timeline

andrew created this revision.Sep 19 2023, 2:09 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 19 2023, 2:09 PM
Herald added a subscriber: imp. · View Herald Transcript
andrew requested review of this revision.Sep 19 2023, 2:09 PM
Harbormaster completed remote builds in B53644: Diff 127533.Sep 19 2023, 2:09 PM
andrew added a child revision: D41917: Check SMCCC is ready before using.Sep 19 2023, 2:09 PM
emaste added a subscriber: kib.Sep 19 2023, 2:25 PM
emaste added inline comments.
sys/arm64/arm64/cpu_errata.c
198

This comment doesn't quite match?

andrew updated this revision to Diff 127564.Sep 20 2023, 11:35 AM

Reword a comment

Harbormaster completed remote builds in B53654: Diff 127564.Sep 20 2023, 11:35 AM
emaste accepted this revision.Sep 20 2023, 11:41 AM
This revision is now accepted and ready to land.Sep 20 2023, 11:41 AM
Closed by commit rGc643e82dba0b: arm64: Fix errata workarounds that depend on smccc (authored by andrew). · Explain WhySep 20 2023, 4:07 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGc643e82dba0b: arm64: Fix errata workarounds that depend on smccc.
andrew added a commit: rGcaf7bc535622: arm64: Fix errata workarounds that depend on smccc.Sep 25 2023, 12:03 PM
andrew added a commit: rG4df1447f2c76: arm64: Fix errata workarounds that depend on smccc.Sep 25 2023, 12:20 PM
andrew added a commit: rG906bcc44641d: arm64: Fix errata workarounds that depend on smccc.Sep 29 2023, 8:22 PM
gordon added a commit: rG485912e051bb: arm64: Fix errata workarounds that depend on smccc.Oct 3 2023, 10:15 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
46 lines

Diff 127564

View Options

sys/arm64/arm64/cpu_errata.c

Loading...