arm64: add support for FIQs
AbandonedPublic
Actions

Authored by kevans on Sep 12 2023, 3:29 PM.

Details

Reviewers

andrew
manu

Group Reviewers

arm64

Summary

Chop off one bit of our MD space for FIQs and route those through INTRNG
to a compatible root controller. These will be used by the Apple
Silicon, which use FIQs for timer interrupts at a minimum. For all
in-tree platforms, this should effectively be a NOP.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53553
Build 50444: arc lint + arc unit

Event Timeline

kevans created this revision.Sep 12 2023, 3:29 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 12 2023, 3:29 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

kevans requested review of this revision.Sep 12 2023, 3:29 PM

Harbormaster completed remote builds in B53553: Diff 127287.Sep 12 2023, 3:29 PM

kevans added a parent revision: D40161: arm64/intrng: add support for FIQs.Sep 12 2023, 3:30 PM

andrew accepted this revision.Sep 12 2023, 5:28 PM

This revision is now accepted and ready to land.Sep 12 2023, 5:28 PM

ehem_freebsd_m5p.com added a subscriber: ehem_freebsd_m5p.com.Fri, Sep 13, 8:25 PM

ehem_freebsd_m5p.com added inline comments.

sys/arm64/include/intr.h
51–61	Why expose these to assembly language? There is an instinct to expose everything, but I sincerely doubt these will ever be used in assembly language. I would prefer to have the `#endif` after line 61 to hint these are never used in assembly.