syslogd: Merge loops
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 3:34 PM.

Details

Reviewers

markj
emaste

Commits

rGbbde787c6668: syslogd: Merge loops

Summary

Merge the two loops that traverse the global filed queue. Both loops'
actions are not dependent on the other, so combining them is safe.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jfree created this revision.Aug 8 2023, 3:34 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 3:34 PM

jfree requested review of this revision.Aug 8 2023, 3:34 PM

jfree added a parent revision: D41369: syslogd: Use process descriptors.

jfree added a child revision: D41371: syslogd: Do not print bad data.

markj accepted this revision.Aug 9 2023, 7:37 PM

This revision is now accepted and ready to land.Aug 9 2023, 7:37 PM

Update after rebase

This revision now requires review to proceed.Aug 10 2023, 11:11 PM

markj accepted this revision.Aug 11 2023, 2:56 PM

This revision is now accepted and ready to land.Aug 11 2023, 2:56 PM

jfree added a parent revision: D41415: syslogd: Do not reap child processes.Aug 11 2023, 6:09 PM

jfree removed a parent revision: D41369: syslogd: Use process descriptors.

so combining them is safe

I think it's not only safe, but more clear/obvious with your change assuming fileds have no (can have no) reference between them.

Closed by commit rGbbde787c6668: syslogd: Merge loops (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:53 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGbbde787c6668: syslogd: Merge loops.

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

syslogd.c

10 lines

Diff 125723

View Options

usr.sbin/syslogd/syslogd.c

syslogd: Merge loopsClosedPublicActions