Paths

Table of Contentst

Differential D41367

syslogd: Style fixes
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 3:31 PM.

Tags

None

Referenced Files

	F102040940: D41367.diff
	Wed, Nov 6, 9:07 PM

	Unknown Object (File)
	Fri, Nov 1, 2:33 PM

	Unknown Object (File)
	Fri, Oct 25, 8:50 PM

	Unknown Object (File)
	Tue, Oct 22, 12:10 PM

	Unknown Object (File)
	Mon, Oct 21, 5:27 AM

	Unknown Object (File)
	Mon, Oct 21, 5:27 AM

	Unknown Object (File)
	Mon, Oct 21, 5:27 AM

	Unknown Object (File)
	Mon, Oct 21, 3:25 AM

View All 63 Files

Subscribers

Details

Reviewers

markj
emaste

Commits

rG929568b9d527: syslogd: Style fixes

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jfree created this revision.Aug 8 2023, 3:31 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 3:31 PM

jfree requested review of this revision.Aug 8 2023, 3:31 PM

jfree added a parent revision: D41366: syslogd: Simplify property filters.

jfree added a child revision: D41368: syslogd: Simplify filed structure.

markj accepted this revision.Aug 9 2023, 7:14 PM

This revision is now accepted and ready to land.Aug 9 2023, 7:14 PM

Update after rebase

This revision now requires review to proceed.Aug 10 2023, 11:10 PM

markj accepted this revision.Aug 11 2023, 2:50 PM

This revision is now accepted and ready to land.Aug 11 2023, 2:50 PM

emaste accepted this revision.Aug 14 2023, 5:25 PM

emaste added inline comments.

usr.sbin/syslogd/syslogd.c
2407	if this `sizeof` was done with the rest you could add the space there. (Not sure if it's `sizeof()` in main or as a result of your sizeof cleanup commit)

jfree added inline comments.Aug 14 2023, 5:41 PM

usr.sbin/syslogd/syslogd.c
2407	if this `sizeof` was done with the rest you could add the space there. (Not sure if it's `sizeof()` in main or as a result of your sizeof cleanup commit) It is sizeof() in main, IIRC. This patch is set before the sizeof() style patch.

Closed by commit rG929568b9d527: syslogd: Style fixes (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:53 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG929568b9d527: syslogd: Style fixes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

52 lines

Diff 127943

usr.sbin/syslogd/syslogd.c

Loading...